Module: Mesa Branch: main Commit: 1a06dbcaed9ed4095ec8878d947935f0f7558cfd URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a06dbcaed9ed4095ec8878d947935f0f7558cfd
Author: Thomas Debesse <[email protected]> Date: Tue Oct 25 05:20:29 2022 +0200 Revert "gallium/clover: pass -no-opaque-pointers to Clang", opaque pointers are now implemented This reverts commit 06e9607478b780c9bcc6e08d69cfbe9020b4602c from !16129. Clover passed -no-opaque-pointers option to Clang to workaround the fact the Clover code was not ported to opaque pointers yet. Opaque pointers are now implemented thanks to !19103 so passing this option to tell Clang to not do opaque pointers while Clover does is actually breaking Clover. Here is an example of what happens when using opaque pointers while passing -no-opaque-pointers at the same time: fatal error: cannot open file 'hawaii-amdgcn-mesa-mesa3d.bc': Opaque pointers are only supported in -opaque-pointers mode This fixes one of the last remaining bits to fully support opaque pointers in Mesa as referenced in #7468, this is the last remaining bit to fully support opaque points in Clover. Signed-off-by: Thomas Debesse <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19290> --- src/gallium/frontends/clover/llvm/invocation.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/gallium/frontends/clover/llvm/invocation.cpp b/src/gallium/frontends/clover/llvm/invocation.cpp index 6c344f98fb1..1e5f3266c26 100644 --- a/src/gallium/frontends/clover/llvm/invocation.cpp +++ b/src/gallium/frontends/clover/llvm/invocation.cpp @@ -226,13 +226,6 @@ namespace { // class to recognize it as an OpenCL source file. #if LLVM_VERSION_MAJOR >= 12 std::vector<const char *> copts; -#if LLVM_VERSION_MAJOR >= 15 - // Since LLVM commit 702d5de4 opaque pointers are enabled by default: - // https://gitlab.freedesktop.org/mesa/mesa/-/issues/6342 - // A better implementation may be doable following suggestions from there: - // https://github.com/llvm/llvm-project/issues/54970#issuecomment-1102254254 - copts.push_back("-no-opaque-pointers"); -#endif for (auto &opt : opts) { if (opt == "-cl-denorms-are-zero") copts.push_back("-fdenormal-fp-math=positive-zero");
