Module: Mesa Branch: main Commit: 3d37950fd9ddc7b43f06b4a5fa710fb7333978ce URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3d37950fd9ddc7b43f06b4a5fa710fb7333978ce
Author: Paulo Zanoni <[email protected]> Date: Fri Jan 13 16:51:59 2023 -0800 anv: check the return value of anv_execbuf_add_bo_bitset() Because anv_execbuf_add_bo_bitset() calls anv_execbuf_add_bo(), which can fail if its memory allocations fail. I have seen dEQP tests exercising memory allocation failures during anv_execbuf_add_bo(), but I don't think the path coming from add_bo_biset() was specifically exercised. Anyway, add the error check just in case. v2: Rebase. Cc: mesa-stable Reviewed-by: Ivan Briano <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: Paulo Zanoni <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20703> --- src/intel/vulkan/i915/anv_batch_chain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/i915/anv_batch_chain.c b/src/intel/vulkan/i915/anv_batch_chain.c index 4e71985a832..705c5a0e7ee 100644 --- a/src/intel/vulkan/i915/anv_batch_chain.c +++ b/src/intel/vulkan/i915/anv_batch_chain.c @@ -292,9 +292,11 @@ setup_execbuf_for_cmd_buffer(struct anv_execbuf *execbuf, { VkResult result; /* Add surface dependencies (BOs) to the execbuf */ - anv_execbuf_add_bo_bitset(cmd_buffer->device, execbuf, - cmd_buffer->surface_relocs.dep_words, - cmd_buffer->surface_relocs.deps, 0); + result = anv_execbuf_add_bo_bitset(cmd_buffer->device, execbuf, + cmd_buffer->surface_relocs.dep_words, + cmd_buffer->surface_relocs.deps, 0); + if (result != VK_SUCCESS) + return result; /* First, we walk over all of the bos we've seen and add them and their * relocations to the validate list.
