Module: Mesa Branch: main Commit: e29a964d020851f7afbeaaafee21ea8b111ee7d5 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e29a964d020851f7afbeaaafee21ea8b111ee7d5
Author: Marcin Ślusarz <[email protected]> Date: Wed Feb 15 13:29:24 2023 +0100 intel/compiler/mesh: follow the type of offset variable This allows copy propagation to kick in, decreasing the overall number of generated instructions. Reviewed-by: Caio Oliveira <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21098> --- src/intel/compiler/brw_mesh.cpp | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/intel/compiler/brw_mesh.cpp b/src/intel/compiler/brw_mesh.cpp index 0f52a31a7ba..f42997da2c6 100644 --- a/src/intel/compiler/brw_mesh.cpp +++ b/src/intel/compiler/brw_mesh.cpp @@ -1199,7 +1199,10 @@ emit_urb_indirect_vec4_write(const fs_builder &bld, for (unsigned q = 0; q < bld.dispatch_width() / 8; q++) { fs_builder bld8 = bld.group(8, q); - fs_reg off = bld8.vgrf(BRW_REGISTER_TYPE_UD, 1); + /* offset is always positive, so signedness doesn't matter */ + assert(offset_src.type == BRW_REGISTER_TYPE_D || + offset_src.type == BRW_REGISTER_TYPE_UD); + fs_reg off = bld8.vgrf(offset_src.type, 1); bld8.MOV(off, quarter(offset_src, q)); bld8.ADD(off, off, brw_imm_ud(base)); bld8.SHR(off, off, brw_imm_ud(2)); @@ -1276,7 +1279,10 @@ emit_urb_indirect_writes(const fs_builder &bld, nir_intrinsic_instr *instr, for (unsigned q = 0; q < bld.dispatch_width() / 8; q++) { fs_builder bld8 = bld.group(8, q); - fs_reg off = bld8.vgrf(BRW_REGISTER_TYPE_UD, 1); + /* offset is always positive, so signedness doesn't matter */ + assert(offset_src.type == BRW_REGISTER_TYPE_D || + offset_src.type == BRW_REGISTER_TYPE_UD); + fs_reg off = bld8.vgrf(offset_src.type, 1); bld8.MOV(off, quarter(offset_src, q)); bld8.ADD(off, off, brw_imm_ud(c + base_in_dwords)); @@ -1381,7 +1387,10 @@ emit_urb_indirect_reads(const fs_builder &bld, nir_intrinsic_instr *instr, for (unsigned q = 0; q < bld.dispatch_width() / 8; q++) { fs_builder bld8 = bld.group(8, q); - fs_reg off = bld8.vgrf(BRW_REGISTER_TYPE_UD, 1); + /* offset is always positive, so signedness doesn't matter */ + assert(offset_src.type == BRW_REGISTER_TYPE_D || + offset_src.type == BRW_REGISTER_TYPE_UD); + fs_reg off = bld8.vgrf(offset_src.type, 1); bld8.MOV(off, quarter(offset_src, q)); bld8.ADD(off, off, brw_imm_ud(base_in_dwords + c));
