Module: Mesa Branch: main Commit: d246948ce36026dfda1b30a69bd4b95a872675ca URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d246948ce36026dfda1b30a69bd4b95a872675ca
Author: Emma Anholt <[email protected]> Date: Tue Feb 21 11:32:41 2023 -0800 anv: Skip BTI RT flush if we're doing an op that doesn't use render targets. rt_flushes emitted on zink sauer.trace --loop=500 -2.02118% +/- 1.15992% (n=8). Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21508> --- src/intel/vulkan/genX_blorp_exec.c | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/genX_blorp_exec.c b/src/intel/vulkan/genX_blorp_exec.c index 006dd1469a0..24aa7f0928d 100644 --- a/src/intel/vulkan/genX_blorp_exec.c +++ b/src/intel/vulkan/genX_blorp_exec.c @@ -260,6 +260,16 @@ blorp_get_l3_config(struct blorp_batch *batch) return cmd_buffer->state.current_l3_config; } +static bool +blorp_uses_bti_rt_writes(const struct blorp_batch *batch, const struct blorp_params *params) +{ + if (batch->flags & (BLORP_BATCH_USE_BLITTER | BLORP_BATCH_USE_COMPUTE)) + return false; + + /* HIZ clears use WM_HZ ops rather than a clear shader using RT writes. */ + return params->hiz_op == ISL_AUX_OP_NONE; +} + static void blorp_exec_on_render(struct blorp_batch *batch, const struct blorp_params *params) @@ -282,10 +292,12 @@ blorp_exec_on_render(struct blorp_batch *batch, * is set due to new association of BTI, PS Scoreboard Stall bit must * be set in this packet." */ - anv_add_pending_pipe_bits(cmd_buffer, - ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT | - ANV_PIPE_STALL_AT_SCOREBOARD_BIT, - "before blorp BTI change"); + if (blorp_uses_bti_rt_writes(batch, params)) { + anv_add_pending_pipe_bits(cmd_buffer, + ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT | + ANV_PIPE_STALL_AT_SCOREBOARD_BIT, + "before blorp BTI change"); + } #endif if (params->depth.enabled && @@ -316,10 +328,12 @@ blorp_exec_on_render(struct blorp_batch *batch, * is set due to new association of BTI, PS Scoreboard Stall bit must * be set in this packet." */ - anv_add_pending_pipe_bits(cmd_buffer, - ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT | - ANV_PIPE_STALL_AT_SCOREBOARD_BIT, - "after blorp BTI change"); + if (blorp_uses_bti_rt_writes(batch, params)) { + anv_add_pending_pipe_bits(cmd_buffer, + ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT | + ANV_PIPE_STALL_AT_SCOREBOARD_BIT, + "after blorp BTI change"); + } #endif /* Calculate state that does not get touched by blorp.
