Module: Mesa Branch: staging/23.0 Commit: 9e777a4b5a3148baa0846f2dd274975983825a11 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e777a4b5a3148baa0846f2dd274975983825a11
Author: Samuel Pitoiset <[email protected]> Date: Mon Feb 27 10:49:16 2023 +0100 radv: fix flushing non-coherent images in EndCommandBuffer() The condition was inverted. This doesn't fix anything known. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21549> (cherry picked from commit 7c62f6fa01d7c0d9d7eabec1c545950af20d0c92) --- .pick_status.json | 2 +- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 8f82a24215a..c092b1fcbfc 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -67,7 +67,7 @@ "description": "radv: fix flushing non-coherent images in EndCommandBuffer()", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 92f5fd3e26b..7ef3093c614 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -6039,7 +6039,7 @@ radv_EndCommandBuffer(VkCommandBuffer commandBuffer) /* Flush noncoherent images on GFX9+ so we can assume they're clean on the start of a * command buffer. */ - if (cmd_buffer->state.rb_noncoherent_dirty && can_skip_buffer_l2_flushes(cmd_buffer->device)) + if (cmd_buffer->state.rb_noncoherent_dirty && !can_skip_buffer_l2_flushes(cmd_buffer->device)) cmd_buffer->state.flush_bits |= radv_src_access_flush( cmd_buffer, VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT |
