Module: Mesa Branch: main Commit: a8691f916be67a5fc4fd731ac032921ce9ebc3dd URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8691f916be67a5fc4fd731ac032921ce9ebc3dd
Author: Dylan Baker <[email protected]> Date: Mon Feb 27 12:18:14 2023 -0800 intel/mi: use 64bit constant for bitshift Coverity complains that we could end up rolling over on a 32bit platform, which isn't really true because of the assertion, but there's also no harm in ensuring that we have exactly the same behavior for both 32 bit and 64 bit platforms. CID: 1515989 Reviewed-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21572> --- src/intel/common/mi_builder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/mi_builder.h b/src/intel/common/mi_builder.h index 43b54e8f122..51ec3cb2249 100644 --- a/src/intel/common/mi_builder.h +++ b/src/intel/common/mi_builder.h @@ -980,7 +980,7 @@ mi_ushr_imm(struct mi_builder *b, struct mi_value src, uint32_t shift) while (shift) { int bit = u_bit_scan(&shift); assert(bit <= 5); - res = mi_ushr(b, res, mi_imm(1 << bit)); + res = mi_ushr(b, res, mi_imm(1ULL << bit)); } return res;
