Module: Mesa
Branch: main
Commit: 6c7400f4e80fa0b912610f00cc42a015cd8800ed
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6c7400f4e80fa0b912610f00cc42a015cd8800ed

Author: Michel Dänzer <[email protected]>
Date:   Fri Apr 21 12:11:05 2023 +0200

vulkan: Fix GetPhysicalDeviceSparseImageFormatProperties definitions

To match the declarations (and the corresponding definition in Vulkan
headers).

Pointed out by GCC 13, e.g.:

../src/intel/vulkan_hasvk/anv_formats.c:1589:6: error: conflicting types for 
'anv_GetPhysicalDeviceSparseImageFormatProperties' due to enum/integer 
mismatch; have 'void(struct VkPhysicalDevice_T *, VkFormat,  VkImageType,  
uint32_t,  VkImageUsageFlags,  VkImageTiling,  uint32_t *, 
VkSparseImageFormatProperties *)' {aka 'void(struct VkPhysicalDevice_T *, 
VkFormat,  VkImageType,  unsigned int,  unsigned int,  VkImageTiling,  unsigned 
int *, VkSparseImageFormatProperties *)'} [-Werror=enum-int-mismatch]
 1589 | void anv_GetPhysicalDeviceSparseImageFormatProperties(
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/intel/vulkan_hasvk/anv_private.h:113,
                 from ../src/intel/vulkan_hasvk/anv_formats.c:24:
src/intel/vulkan_hasvk/anv_entrypoints.h:120:30: note: previous declaration of 
'anv_GetPhysicalDeviceSparseImageFormatProperties' with type 'void(struct 
VkPhysicalDevice_T *, VkFormat,  VkImageType,  VkSampleCountFlagBits,  
VkImageUsageFlags,  VkImageTiling,  uint32_t *, VkSparseImageFormatProperties 
*)' {aka 'void(struct VkPhysicalDevice_T *, VkFormat,  VkImageType,  
VkSampleCountFlagBits,  unsigned int,  VkImageTiling,  unsigned int *, 
VkSparseImageFormatProperties *)'}
  120 |   VKAPI_ATTR void VKAPI_CALL 
anv_GetPhysicalDeviceSparseImageFormatProperties(VkPhysicalDevice 
physicalDevice, VkFormat format, VkImageType type, VkSampleCountFlagBits 
samples, VkImageUsageFlags usage, VkImageTiling tiling, uint32_t* 
pPropertyCount, VkSparseImageFormatProperties* pProperties);
      |                              
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22718>

---

 src/gallium/frontends/lavapipe/lvp_formats.c | 2 +-
 src/imagination/vulkan/pvr_formats.c         | 2 +-
 src/intel/vulkan_hasvk/anv_formats.c         | 2 +-
 src/panfrost/vulkan/panvk_formats.c          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gallium/frontends/lavapipe/lvp_formats.c 
b/src/gallium/frontends/lavapipe/lvp_formats.c
index 7c206db72bb..ab8b6efcbfe 100644
--- a/src/gallium/frontends/lavapipe/lvp_formats.c
+++ b/src/gallium/frontends/lavapipe/lvp_formats.c
@@ -420,7 +420,7 @@ VKAPI_ATTR void VKAPI_CALL 
lvp_GetPhysicalDeviceSparseImageFormatProperties(
     VkPhysicalDevice                            physicalDevice,
     VkFormat                                    format,
     VkImageType                                 type,
-    uint32_t                                    samples,
+    VkSampleCountFlagBits                       samples,
     VkImageUsageFlags                           usage,
     VkImageTiling                               tiling,
     uint32_t*                                   pNumProperties,
diff --git a/src/imagination/vulkan/pvr_formats.c 
b/src/imagination/vulkan/pvr_formats.c
index 6000fdd72ea..ad40ba7ae81 100644
--- a/src/imagination/vulkan/pvr_formats.c
+++ b/src/imagination/vulkan/pvr_formats.c
@@ -924,7 +924,7 @@ void pvr_GetPhysicalDeviceSparseImageFormatProperties(
    VkPhysicalDevice physicalDevice,
    VkFormat format,
    VkImageType type,
-   uint32_t samples,
+   VkSampleCountFlagBits samples,
    VkImageUsageFlags usage,
    VkImageTiling tiling,
    uint32_t *pNumProperties,
diff --git a/src/intel/vulkan_hasvk/anv_formats.c 
b/src/intel/vulkan_hasvk/anv_formats.c
index 0254a20d809..df0fc6c03de 100644
--- a/src/intel/vulkan_hasvk/anv_formats.c
+++ b/src/intel/vulkan_hasvk/anv_formats.c
@@ -1590,7 +1590,7 @@ void anv_GetPhysicalDeviceSparseImageFormatProperties(
     VkPhysicalDevice                            physicalDevice,
     VkFormat                                    format,
     VkImageType                                 type,
-    uint32_t                                    samples,
+    VkSampleCountFlagBits                       samples,
     VkImageUsageFlags                           usage,
     VkImageTiling                               tiling,
     uint32_t*                                   pNumProperties,
diff --git a/src/panfrost/vulkan/panvk_formats.c 
b/src/panfrost/vulkan/panvk_formats.c
index 96d4aa4cd6f..4963b18672f 100644
--- a/src/panfrost/vulkan/panvk_formats.c
+++ b/src/panfrost/vulkan/panvk_formats.c
@@ -462,7 +462,7 @@ fail:
 void
 panvk_GetPhysicalDeviceSparseImageFormatProperties(
    VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type,
-   uint32_t samples, VkImageUsageFlags usage, VkImageTiling tiling,
+   VkSampleCountFlagBits samples, VkImageUsageFlags usage, VkImageTiling 
tiling,
    uint32_t *pNumProperties, VkSparseImageFormatProperties *pProperties)
 {
    /* Sparse images are not yet supported. */

Reply via email to