Module: Mesa Branch: main Commit: 21c7b55f6fdb91b1312423844e4d6d036dc2f09c URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=21c7b55f6fdb91b1312423844e4d6d036dc2f09c
Author: Lionel Landwerlin <[email protected]> Date: Fri May 19 11:10:01 2023 +0300 intel/fs: fix size_read() for LOAD_PAYLOAD With Anv/Zink, the piglit test : arb_shader_storage_buffer_object-max-ssbo-size -auto -fbo fsexceed is failing validation after copy propagation : load_payload(8) vgrf15:F, vgrf1+0.12<0>:F, vgrf1+0.0<0>:F, vgrf1+0.4<0>:F, vgrf1+0.8<0>:F, vgrf1+0.12<0>:F ../src/intel/compiler/brw_fs_validate.cpp:191: A <= B failed A = inst->src[i].offset / REG_SIZE + regs_read(inst, i) = 2 B = alloc.sizes[inst->src[i].nr] = 1 In most cases it works because src[0] would be at offset 0 and so reading a full reg passes validation, but Anv/Zink started emitting slightly different code adding an offset maybe the size read 2 GRFs. Signed-off-by: Lionel Landwerlin <[email protected]> Reviewed-by: Francisco Jerez <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23126> --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 89d5b0e7e0a..85f7d881bc7 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -877,7 +877,7 @@ fs_inst::size_read(int arg) const case SHADER_OPCODE_LOAD_PAYLOAD: if (arg < this->header_size) - return REG_SIZE; + return retype(src[arg], BRW_REGISTER_TYPE_UD).component_size(8); break; case CS_OPCODE_CS_TERMINATE:
