Module: Mesa
Branch: main
Commit: bfb092b955516d5ff0d1cfb73de80fed30cec6c3
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfb092b955516d5ff0d1cfb73de80fed30cec6c3

Author: Vinson Lee <[email protected]>
Date:   Sat Jun  3 16:32:44 2023 -0700

nv50: Fix memory leak in error path

Fix defect reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable memobj going out of scope leaks the storage it points 
to.

Fixes: a1571333804 ("nvc0/nv50: support and enable EXT_memory_object*")
Signed-off-by: Vinson Lee <[email protected]>
Reviewed-by: Karol Herbst <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23417>

---

 src/gallium/drivers/nouveau/nv50/nv50_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/nouveau/nv50/nv50_resource.c 
b/src/gallium/drivers/nouveau/nv50/nv50_resource.c
index 6e215be55a5..2e2961c88a8 100644
--- a/src/gallium/drivers/nouveau/nv50/nv50_resource.c
+++ b/src/gallium/drivers/nouveau/nv50/nv50_resource.c
@@ -109,7 +109,7 @@ nv50_memobj_create_from_handle(struct pipe_screen *screen,
 
    memobj->bo = nouveau_screen_bo_from_handle(screen, handle, &memobj->stride);
    if (memobj->bo == NULL) {
-      FREE(memobj->bo);
+      FREE(memobj);
       return NULL;
    }
    memobj->handle = handle;

Reply via email to