Module: Mesa Branch: staging/23.2 Commit: 98faee3c969e9899f8b513f41e252ebf28870edf URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=98faee3c969e9899f8b513f41e252ebf28870edf
Author: Luigi Santivetti <[email protected]> Date: Wed Aug 2 14:32:12 2023 +0100 pvr: do not claim support for ASTC texture compression We don't support any ASTC formats yet, but the textureCompressionASTC_LDR feature was incorrectly set to true. Fix this by setting it to false and don't advertise ASTC support for texture compression. Fixes dEQP-VK.api.info.format_properties.compressed_formats Fixes: 8991e646 ("pvr: Add a Vulkan driver for Imagination Technologies PowerVR Rogue GPUs") Signed-off-by: Luigi Santivetti <[email protected]> Reviewed-by: Karmjit Mahil <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24448> (cherry picked from commit c5a6e88c4e816ded6105b74f101528eb004e0581) --- .pick_status.json | 2 +- src/imagination/vulkan/pvr_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index f84de1ebef6..ffc26e9d1a4 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -10424,7 +10424,7 @@ "description": "pvr: do not claim support for ASTC texture compression", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "8991e646411b73c1e03278267c80758e921f2352", "notes": null diff --git a/src/imagination/vulkan/pvr_device.c b/src/imagination/vulkan/pvr_device.c index 9f380c4f8c5..147e766d074 100644 --- a/src/imagination/vulkan/pvr_device.c +++ b/src/imagination/vulkan/pvr_device.c @@ -188,7 +188,7 @@ static void pvr_physical_device_get_supported_features( .multiViewport = false, .samplerAnisotropy = false, .textureCompressionETC2 = true, - .textureCompressionASTC_LDR = PVR_HAS_FEATURE(dev_info, astc), + .textureCompressionASTC_LDR = false, .textureCompressionBC = false, .occlusionQueryPrecise = false, .pipelineStatisticsQuery = false,
