Module: Mesa Branch: staging/23.2 Commit: 6395f22216b38ca60b8c8d8197fbd94f659b4164 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6395f22216b38ca60b8c8d8197fbd94f659b4164
Author: Matt Turner <[email protected]> Date: Thu Aug 10 14:12:24 2023 -0400 Revert "intel/fs: only avoid SIMD32 if strictly inferior in throughput" This reverts commit 6b494745be0900a67004d6f3e4b730c3cd67da79. The logic is not entirely correct: the comparison is between two static-analysis estimates of a dynamic system with variables that aren't captured by the shader source, so using ">" will always have greater potential to cause regressions whenever the performance difference between the two builds is something not captured by the static model, no matter how much the model is improved. Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9262 (cherry picked from commit d142c845d05732f7858839493e0dba6a1fa5d6c0) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25377> --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index c89ef6621ae..8e28a072bfd 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -7678,7 +7678,7 @@ brw_compile_fs(const struct brw_compiler *compiler, } else { const performance &perf = v32->performance_analysis.require(); - if (!INTEL_DEBUG(DEBUG_DO32) && throughput > perf.throughput) { + if (!INTEL_DEBUG(DEBUG_DO32) && throughput >= perf.throughput) { brw_shader_perf_log(compiler, params->log_data, "SIMD32 shader inefficient\n"); } else {
