Module: Mesa
Branch: staging/23.2
Commit: 94ed71dad161edb01ee7acaae02e555af3e5dcac
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=94ed71dad161edb01ee7acaae02e555af3e5dcac

Author: Rohan Garg <[email protected]>
Date:   Wed Oct 11 12:30:58 2023 +0200

anv: turn off non zero fast clears for CCS_E

This helps fix a performance regression on games such as F1 22 and RDR2.
Turning on non zero fast clears causes additional partial resolves for
these games that degrades performance. Let's turn off non zero fast
clears till we can elimiate the partial resolves.

Signed-off-by: Rohan Garg <[email protected]>
Reviewed-by: Nanley Chery <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25655>

---

 src/intel/vulkan/anv_image.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 017cd6b84b2..697c74264e8 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -351,6 +351,15 @@ can_fast_clear_with_non_zero_color(const struct 
intel_device_info *devinfo,
    if (image->planes[plane].aux_usage == ISL_AUX_USAGE_FCV_CCS_E)
       return false;
 
+   /* Turning on non zero fast clears for CCS_E introduces a performance
+    * regression for games such as F1 22 and RDR2 by introducing additional
+    * partial resolves. Let's turn non zero fast clears back off till we can
+    * fix performance.
+    */
+   if (image->planes[plane].aux_usage == ISL_AUX_USAGE_CCS_E &&
+       devinfo->ver >= 12)
+      return false;
+
    /* Non mutable image, we can fast clear with any color supported by HW.
     */
    if (!(image->vk.create_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT))

Reply via email to