URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ccb51b87c4e81fafc15da87123fe7e53c2a5e01 Author: Felix DeGrood <felix.j.degr...@intel.com> Date: Tue Oct 31 23:15:37 2023 +0000
anv: remove CS_FLUSH from query regression Fixes performance regression introduced by prior refactoring of pipe control code that unnecessarily added CS_FLUSH to query start and end. Issue was diagnosed by Ben L (thank you!) Confirmed this restores performance on: * Borderlands3 +2% * Payday +3% * Factorio +3% * HogwartsLegacy +4% * Ghostrunner +7% Fixes: 6dc95685 (convert genX_query pipe controls to use pc helper) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25983> (cherry picked from commit aa23120e4fc674d7da42c4895aa204f300155105) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b58483b78f89adf652d794a8d1e056d1b01b2a21 Author: José Expósito <jexpo...@redhat.com> Date: Fri Nov 3 14:15:06 2023 +0100 zink: Fix crash on zink_create_screen error path The `zink_internal_create_screen()` function can fail before `screen->loader_lib` and/or `screen->instance` are initialized. The `zink_destroy_screen()` doesn't check those cases and crashes. The error was found by Fedora's CI. The back trace is available at [1]. [1] https://bodhi.fedoraproject.org/updates/FEDORA-2023-c39f82c465 Fixes: 0c2045553fe4 ("zink: use screen destructor for creation fails") Reviewed-by: Erik Faye-Lund <erik.faye-l...@collabora.com> Signed-off-by: José Expósito <jexpo...@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26029> (cherry picked from commit 8a635e516ebb12411de8055c3405f36be43269b3) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5288dfc24a0df541a4f66185a063349041bd7f3 Author: Yonggang Luo <luoyongg...@gmail.com> Date: Thu Nov 2 04:43:10 2023 +0800 nvk: Should use alignment instead of align align is a function, don't know why align > 0 is working Fixes: 87686a22205 ("nvk: Rework side-band data upload") Signed-off-by: Yonggang Luo <luoyongg...@gmail.com> Reviewed-by: Faith Ekstrand <faith.ekstr...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26035> (cherry picked from commit 5e9dcffffde8b4ecf78531c0285a0d296e1fc7a9) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f88b1dd1e85c9c115e044895b390b7e27f66ef7f Author: Eric Engestrom <e...@engestrom.ch> Date: Sat Nov 4 14:16:31 2023 +0000 .pick_status.json: Mark 8dda860f83ac30d042dc6beb4438cc925d1fd130 as denominated URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ec72dceb17f836a6b7ff1c0bace0b424f911455 Author: Chia-I Wu <olva...@gmail.com> Date: Wed Nov 1 17:53:44 2023 -0700 radv: stop using vk_render_pass_state::render_pass vk_render_pass_state::pipeline_flags is derived from vk_get_pipeline_rendering_flags and has the info we need. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10074 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26000> (cherry picked from commit 227300345ed38377190b0eaf08694d5c42ee7e60) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ebbecb9d5224e4bae3fe104eb1b0a52823003738 Author: David Rosca <now...@gmail.com> Date: Thu Nov 2 09:29:25 2023 +0100 frontends/va: Map decoder and postproc surfaces for reading If application requests to map surface that was most recently used as decoder or postproc target and also doesn't explicitly set the map flags (vaMapBuffer2) it's very likely the intent is to read from this surface, so we need to map it as such. This fixes regression on radeonsi where mapping NV12 surfaces for reading would fail with applications using vaDeriveImage. The reason for this is that the VA frontend doesn't allow vaDeriveImage for interlaced surfaces so the applications would use vaGetImage fallback, but radeonsi doesn't allocate NV12 surfaces as interlaced anymore. This also fixes mapping other formats surfaces (P010, RGBx, ...) for reading, which never worked before. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9935 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10048 Reviewed-by: Leo Liu <leo....@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26008> (cherry picked from commit c638e61ef5e2e7de097a9b5850eff75022330f68) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7afb7e9a42b68014cf7cb4e41f4c2ac683fbe881 Author: Rob Clark <robdcl...@chromium.org> Date: Wed Nov 1 09:42:21 2023 -0700 freedreno/drm: Fix race in zombie import The check for the zombie case (racing with final unref of the bo vs removal from table) must be atomic. Fixes spec@ext_image_dma_buf_import@ext_image_dma_buf_import-refcount-multithread Fixes: a192923f99e1 ("freedreno/drm: Restart import on zombie race") Signed-off-by: Rob Clark <robdcl...@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25995> (cherry picked from commit 6ac133c646dd4f6f9d8f644b24da6aeae95c1ce3) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=28e36118af58513ffe94f8cf9be4a8de39e74ae0 Author: antonino <antonino.manisca...@collabora.com> Date: Thu Nov 2 18:03:41 2023 +0100 nir: don't take the derivative of the array index in `nir_lower_tex` Previosuly when lowering to txd for sampler array the index would be derived as well, therefore the resulting derivative would have been a vec with one more component than what the txd instruction expects. This patch truncates the coordinate vector in this case to make sure the index is not derived. Fixes: b154a4154b4 ("nir/lower_tex: rewrite tex/txb -> txd/txl before saturating srcs") Reviewed-by: Faith Ekstrand <faith.ekstr...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26012> (cherry picked from commit 4a627af0e3670d409d8140c1f9ee1c7ac86b5ddf) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=35fea70555b53fc6daeb0323a3c071add8d334aa Author: Gert Wollny <gert.wol...@collabora.com> Date: Thu Nov 2 21:39:42 2023 +0100 r600/sfn: Fixup component count only if intrinsic has it Fixes: 33d878e r600/sfn: Handle load_global in 64 to vec2 lowering Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24229> (cherry picked from commit 28b79b2ea5d13f2499d78f903a335383bb38e5c1) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb41ceec14b113b6fe0e7b88b8482033cae8d14a Author: Gert Wollny <gert.wol...@collabora.com> Date: Thu Nov 2 21:24:17 2023 +0100 r600: Link with libgalliumvl, when enabling rusticl this is needed Fixes: 33673bcc2ab84de0b1ff35519e7d7a58ef572fba rusticl: stop linking with libgalliumvl Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24229> (cherry picked from commit 1662897294a3b6b0f8b6004163c016722c634651) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0afd2930fd3a929939bfbf098dacdc87ea002d14 Author: Karol Herbst <kher...@redhat.com> Date: Thu Nov 2 20:41:25 2023 +0100 nvc0: implement PIPE_CAP_TIMER_RESOLUTION This allows rusticl to create profiling queues. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10042 Fixes: 660f2eabe11 ("gallium: add PIPE_CAP_TIMER_RESOLUTION") Signed-off-by: Karol Herbst <kher...@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26016> (cherry picked from commit 7b419215048d63b33d3693206a7319d933c075d8) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4cbcc74d8faebf8f614be45e54c36b012aa7d046 Author: Connor Abbott <cwabbo...@gmail.com> Date: Thu Nov 2 18:29:31 2023 +0100 v3d/ci: Remove minetest trace For the same reason as the previous commit. For examples of commits causing spurious changes see 8019a1b9 and d89ca14e. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25864> (cherry picked from commit 2313a517d2ddb6395eab802949b2f8461397b1d0) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ab2a7f32e63fccc3cb68a0db9808aecdd7fabe4a Author: Connor Abbott <cwabbo...@gmail.com> Date: Tue Oct 24 12:23:28 2023 +0200 freedreno/ci: Remove minetest trace I've repeatedly seen minor pixel changes due to changes that only affect RA decisions, most recently in !22072. We changed the trace to hopefully remove a use of texture() in control flow, but it seems there are more, or the problem is something slightly different like reading uninitialized values. On the other hand minetest has never actually caught an issue for me that some other trace hasn't also caught. Just remove it. Cc: mesa-stable Acked-by: David Heidelberg <david.heidelb...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25864> (cherry picked from commit 16214710caaacf4fb8539498a3eb774644921249) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2cfc7776bd6d27715b89606bf9f7a3f33dd83025 Author: Faith Ekstrand <faith.ekstr...@collabora.com> Date: Wed Apr 19 17:18:45 2023 -0500 nir: Handle wildcards with casts in copy_prop_vars If we're propagating a copy from a cast where the copy copies an entire array, we end up with something like &((S *)ssa_N)->f[*] in the source where a wildcard has a cast in its parent chain. If we then try to propagate the read into a non-wildcard array load, we have to specialize the wildcard. This breaks because nir_build_deref_follower() doesn't handle casts. Since we know a priori that, because wildcards are only generated by copy_deref on arrays, we cannot have a cast with a wildcard parent so simply chasing the source deref to the first wildcard will ensure that any casts in the deref are handled properly. Fixes: ba2bd20f8732 ("nir: Rework opt_copy_prop_vars to use deref instructions") Acked-by: Alyssa Rosenzweig <aly...@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22580> (cherry picked from commit 15ab4d397fbd24ac09daab03cc9cd0b750dbace2) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=844e330299aa7f85c231ef304f152353b356b6e7 Author: Yiwei Zhang <zzyi...@chromium.org> Date: Wed Nov 1 01:14:00 2023 -0700 venus: fix query feedback batch leak and race upon submission Summary: - fixed the combined query batches leak - fixed the race condition of accessing feedback cmd pool - very scoped code refactor Cc: 23.3 <mesa-stable> Fixes: 5b24ab91e43 ("venus: switch to unconditionally deferred query feedback") Signed-off-by: Yiwei Zhang <zzyi...@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25988> (cherry picked from commit ae3b022fa0568e048ce2013affbd2ca60cc42ec6) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6f99c62086bfc1d865e0bc5a1c231ffe1acf60a6 Author: Rob Clark <robdcl...@chromium.org> Date: Thu Nov 2 07:29:51 2023 -0700 tu/virtio: Fix timeline semaphore support Fixes: f17c5297d7a0 ("tu: Add virtgpu support") Signed-off-by: Rob Clark <robdcl...@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981> (cherry picked from commit ceeab44fd1ff116b5a3906044fc33588b65dcbda) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2bd7e293bfed5d2956a5dcb3e17555d0f6817986 Author: Rob Clark <robdcl...@chromium.org> Date: Thu Nov 2 07:29:23 2023 -0700 tu/msm: Fix timeline semaphore support Fixes: daefc6e2a40b ("turnip: prep work for timeline semaphore support") Signed-off-by: Rob Clark <robdcl...@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981> (cherry picked from commit 79b907f9412971b8f6316e1de757a2c3cfdbc603) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8e266b7b3bd4985467059a7cbdfe14ec68199ec Author: Rhys Perry <pendingchao...@gmail.com> Date: Wed Oct 11 14:46:20 2023 +0100 radv: skip radv_remove_varyings for mesh shaders Fixes compilation of a Talos Principle 2 shader. Signed-off-by: Rhys Perry <pendingchao...@gmail.com> Reviewed-by: Timur Kristóf <timur.kris...@gmail.com> Fixes: 9fa9782c1790 ("radv: stop compiling a noop FS when the application doesn't provide a FS") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659> (cherry picked from commit 0a418561dab43a41f21ab209367f88c2ed9eb4a5) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e451512431d9a8336acfcbd8ae2aa24fdec5f02 Author: Rhys Perry <pendingchao...@gmail.com> Date: Wed Oct 11 14:43:03 2023 +0100 radv: call lower_array_deref_of_vec before lower_io_arrays_to_elements nir_lower_io_arrays_to_elements does not support array derefs of vectors, even when nir_deref_instr_is_known_out_of_bounds is fixed. They can occur with mesh shaders. Found by inspection. Signed-off-by: Rhys Perry <pendingchao...@gmail.com> Reviewed-by: Timur Kristóf <timur.kris...@gmail.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659> (cherry picked from commit ed12be533e2673b08e958be32fbe5d6af2737fbc) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8081cb909bde826d76312f93e2dcafb29eba34c1 Author: Faith Ekstrand <faith.ekstr...@collabora.com> Date: Wed Nov 1 15:38:35 2023 -0500 nir: add deref follower builder for casts. This fixes intel_clc builds with llvm 17 on gfx125_bvh_build_DFS_DFS where it dies in the lower indirect derefs pass. Co-authored-by: Dave Airlie <airl...@redhat.com> Fixes: 4a4e1757381c ("nir: Support deref instructions in lower_var_copies") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25536> (cherry picked from commit 6388896985da7495ad0968322491953894d29637) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=11398ee00f16a6c4c4c0302f9bbf0bf0385b5ab7 Author: Gert Wollny <gert.wol...@collabora.com> Date: Wed Oct 25 22:30:37 2023 +0200 r600: Add callbacks for get_driver_uuid and get_device_uuid v2: Evaluate driver ID dynamically (Adam Jackson) v3: Align the stars (Triang3l) v4: include "r600" in driver ID for UUID evaluation (Triang3l) v5: remove unused local variable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10040 CC: mesa-stable Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25895> (cherry picked from commit 3ab51c7ebd1e7a65bd928b6142423123c7552927) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5443e6619080b5a28144a33e53bc7a519f1a6066 Author: LingMan <18294-ling...@users.noreply.gitlab.freedesktop.org> Date: Sat Nov 4 12:51:51 2023 +0100 rusticl: Show an error message if the version of bindgen can't be detected bindgen 0.69.0 broke the `--version` switch, resulting in misleading errors about requiring at least bindgen 0.62 or about unexpected arguments. Ideally the build system would fetch the correct bindgen version automatically like cargo does. Until then, provide a hopefully more helpful error message to the user. Reviewed-by: Karol Herbst <kher...@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26046> (cherry picked from commit 1f1ec1c6bcc2a32a3c1df8c2cc7a2f4e7139b7ec) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfbd6f22c353d761d70b9d64baca8cf2b9c93dd4 Author: LingMan <18294-ling...@users.noreply.gitlab.freedesktop.org> Date: Tue Oct 24 05:47:06 2023 +0200 rusticl: Show an error message if the build is attempted with an outdated bindgen version Ideally the build system would fetch the correct bindgen version automatically like cargo does. Until then, provide an error message that is hopefully more helpful than whatever cryptic error the build runs into otherwise. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9457 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10029 Reviewed-by: Karol Herbst <kher...@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25859> (cherry picked from commit 1cc26e8b6657b5097995470ced9ae9cc7b6f01b9) URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=364214f1c71ae0be65783a6e9f0ec1d0ee5a40b2 Author: Eric Engestrom <e...@engestrom.ch> Date: Sat Nov 4 14:09:43 2023 +0000 .pick_status.json: Update to 1f1ec1c6bcc2a32a3c1df8c2cc7a2f4e7139b7ec