URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8b2426419b3bad3bfbea8877e40442f62c26d2e Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Dec 5 17:16:34 2023 -0800
intel/compiler: Use reference instead of pointer for fs_visitor Per Ian suggestion. Also clear up a few unnecessary casts around the code and use `s` for fs_visitor ("shader"). Note to include a reference in ntf we need to set it during initialization, so create an explicit mem_ctx for it. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=77ab74ccc2d2610c6a8001daaf681f6b21fb207b Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Dec 5 15:27:29 2023 -0800 intel/compiler: Use reference instead of pointer for nir_to_brw_state Per Ian suggestion. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e5fcccd0174be439b04cb63bed24ea8373b78c1 Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Dec 5 15:11:09 2023 -0800 intel/compiler: Create and use nir_to_brw() function Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=38a42e5aa1f3fe5f5a4d475fdfd95bb51548b4c0 Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Nov 21 10:12:09 2023 -0800 intel/compiler: Add ctor to fs_builder that just takes the shader Uses the dispatch_width from the shader (fs_visitor). This was not possible before because the dispatch_width was not part of backend_shader. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf730adc588bcdd87fe8b3eb0a1894038d105438 Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Nov 21 09:58:55 2023 -0800 intel/compiler: Make fs_builder include fs_visitor and not the other way This will allow fs_builder have a reference to an fs_visitor (a "fs_shader" really), instead of a reference to a backend_shader. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5032c4d528efe0519efb9fe83f5a9945da08006 Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Nov 21 07:49:02 2023 -0800 intel/compiler: Make fs_visitor not depend on fs_builder At this point this is more a header dependency due to inline functions, so shuffle them around. The end goal is to allow fs_builder have a reference to a fs_visitor (really a fs_shader). Note the header is still included, a later patch will move the includes to the call-sites. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f991dec00dfc4f1452c5d1c8815a4c20d3bd88b Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Nov 21 07:35:51 2023 -0800 intel/compiler: Remove fs_visitor::bld Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b8ec015f27e879438216f20198e907419ee2f13 Author: Caio Oliveira <caio.olive...@intel.com> Date: Tue Nov 21 09:47:18 2023 -0800 intel/compiler: Don't use fs_visitor::bld in remaining places The remaining users can simply create a new builder at_end() if needed. In many places a new builder object is already being constructed, so just give more specific instructions. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c73c1aa4964ac571d5ebe1177a0cea0fdc81e53a Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 22:11:23 2023 -0800 intel/compiler: Annotate and use nir_to_brw_state::bld Use the "current bld" in nir_to_brw_state more widely, and also replace it with an annotated version when applicable (to associate it with a NIR instruction being lowered). After filling a block we reset it back to the original value. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=34c28680b12f1b4372bd12915b49fd5e9dcf4324 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 22:00:28 2023 -0800 intel/compiler: Stop using fs_visitor::bld field in NIR conversion Provide its own builder in nir_to_brw_state. Will allow eventually remove the one in fs_visitor. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=79735fa7839540a22d291d5636969929fb853b86 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 21:36:14 2023 -0800 intel/compiler: Move remaining NIR conversion fields to nir_to_brw_state Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cb189636dd13916975493784375bd736a5d0f15 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 21:21:54 2023 -0800 intel/compiler: Move nir_ssa_value into a local structure Create a nir_to_brw_state struct that is valid only during the NIR to backend translation and use it for nir_ssa_values array. This removes some NIR specific handling out of the fs_visitor -- nowadays effectively an fs_shader. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=afe75d65be29e68a787d5edd697f32ab000dad04 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 15:21:11 2023 -0800 intel/compiler: Make NIR resources helpers static Remove get_nir_src_block() since it is not used anywhere. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a7a27ee95ead859abcf42e8b8c7fb96d21aa4913 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 15:05:03 2023 -0800 intel/compiler: Make NIR atomic conversion functions static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5777943381b43456fd1fdde433092d4f8f073be9 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 14:55:21 2023 -0800 intel/compiler: Make non-intrinsic NIR conversion functions static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2385d6087aafce919f87dacc54290a7a77f0a3e4 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 14:50:48 2023 -0800 intel/compiler: Make setup functions of NIR emission static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3899e6b1d84fcc69d82cd23acdc8d3c3c8b0b0c0 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 14:42:06 2023 -0800 intel/compiler: Make functions for NIR control flow conversion static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=860ec33f9abb1d40d1d70d6edf1dcf3831b9751c Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 13:25:36 2023 -0800 intel/compiler: Make more functions in NIR conversion static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=acca9dbf6b73e4d46bff2d5fdab3e0e53c37096d Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 12:13:47 2023 -0800 intel/compiler: Make a NIR intrinsic emission functions static Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c12460b01efb601faf3511c7d84a619e7b95e0b5 Author: Caio Oliveira <caio.olive...@intel.com> Date: Fri Nov 17 17:17:25 2023 -0800 intel/compiler: Move NIR emission code to brw_fs_nir.cpp This is a preparation to reorganize NIR emission code. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1ef6415d222324b9303ffa57fc1d978654eb7420 Author: Caio Oliveira <caio.olive...@intel.com> Date: Mon Nov 20 14:14:27 2023 -0800 intel/compiler: Remove unused headers Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26323>