Module: Mesa Branch: main Commit: 8f1674582119eb4532979c0fea382d2a1a66cff0 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8f1674582119eb4532979c0fea382d2a1a66cff0
Author: Daniel Schürmann <dan...@schuermann.dev> Date: Mon Oct 30 16:19:20 2023 +0100 aco: fix should_form_clause() for memory instructions without operands In particular, this applies to s_memtime and s_memrealtime. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25676> --- src/amd/compiler/aco_ir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp index cd8d1efee80..fa377a0f9b2 100644 --- a/src/amd/compiler/aco_ir.cpp +++ b/src/amd/compiler/aco_ir.cpp @@ -1308,6 +1308,9 @@ should_form_clause(const Instruction* a, const Instruction* b) if (a->format != b->format) return false; + if (a->operands.empty() || b->operands.empty()) + return false; + /* Assume loads which don't use descriptors might load from similar addresses. */ if (a->isFlatLike()) return true;
