Module: Mesa
Branch: main
Commit: 1c042537e674fd9d65947a65ea994d5a280f67af
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c042537e674fd9d65947a65ea994d5a280f67af

Author: Christian Gmeiner <cgmei...@igalia.com>
Date:   Wed Jan  3 19:21:51 2024 +0100

pan/mdg: Use nir_builder for load_sampler_lod_parameters_pan

Found by code inspection as I need something similar for etnaviv.

Signed-off-by: Christian Gmeiner <cgmei...@igalia.com>
Reviewed-by: Alyssa Rosenzweig <aly...@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26879>

---

 src/panfrost/midgard/midgard_errata_lod.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/panfrost/midgard/midgard_errata_lod.c 
b/src/panfrost/midgard/midgard_errata_lod.c
index 0fa2d5e50bd..bd9b370a966 100644
--- a/src/panfrost/midgard/midgard_errata_lod.c
+++ b/src/panfrost/midgard/midgard_errata_lod.c
@@ -45,17 +45,11 @@ nir_lod_errata_instr(nir_builder *b, nir_instr *instr, void 
*data)
    if (tex->op != nir_texop_txl)
       return false;
 
-   /* Let's grab the sampler parameters */
-   nir_intrinsic_instr *l = nir_intrinsic_instr_create(
-      b->shader, nir_intrinsic_load_sampler_lod_parameters_pan);
-   l->num_components = 3;
-   nir_def_init(&l->instr, &l->def, 3, 32);
-
    /* TODO: Indirect samplers, separate sampler objects XXX */
-   l->src[0] = nir_src_for_ssa(nir_imm_int(b, tex->texture_index));
+   nir_def *sampler = nir_imm_int(b, tex->texture_index);
 
-   nir_builder_instr_insert(b, &l->instr);
-   nir_def *params = &l->def;
+   /* Let's grab the sampler parameters */
+   nir_def *params = nir_load_sampler_lod_parameters_pan(b, 3, 32, sampler);
 
    /* Extract the individual components */
    nir_def *min_lod = nir_channel(b, params, 0);

Reply via email to