Module: Mesa
Branch: staging/23.3
Commit: 1d5bec466d9bd65fed91469b3cffed757062d18a
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1d5bec466d9bd65fed91469b3cffed757062d18a
Author: Vinson Lee <v...@freedesktop.org>
Date: Fri Dec 29 00:08:24 2023 -0800
ac/rgp: Fix single-bit-bitfield-constant-conversion warning
../src/amd/common/ac_rgp.c:119:48: warning: implicit truncation from 'int' to a
one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]
119 | header->flags.is_semaphore_queue_timing_etw = 1;
| ^ ~
Fixes: ed0c8522437 ("radv: add initial SQTT files generation support")
Signed-off-by: Vinson Lee <v...@freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26839>
(cherry picked from commit 568f61787a5cd1a69c799d935c364138ff415a1e)
---
.pick_status.json | 2 +-
src/amd/common/ac_rgp.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index acd34d40315..3ebf1ae3b5d 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -624,7 +624,7 @@
"description": "ac/rgp: Fix single-bit-bitfield-constant-conversion
warning",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": "ed0c852243719c6bac420de50a2f1061250e5b51",
"notes": null
diff --git a/src/amd/common/ac_rgp.c b/src/amd/common/ac_rgp.c
index 71c61f54975..c6a748410e3 100644
--- a/src/amd/common/ac_rgp.c
+++ b/src/amd/common/ac_rgp.c
@@ -79,9 +79,9 @@ struct sqtt_file_chunk_header {
struct sqtt_file_header_flags {
union {
struct {
- int32_t is_semaphore_queue_timing_etw : 1;
- int32_t no_queue_semaphore_timestamps : 1;
- int32_t reserved : 30;
+ uint32_t is_semaphore_queue_timing_etw : 1;
+ uint32_t no_queue_semaphore_timestamps : 1;
+ uint32_t reserved : 30;
};
uint32_t value;
