Module: Mesa
Branch: master
Commit: dc886ba1391d7d890bd1f5532bc14553e883a418
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc886ba1391d7d890bd1f5532bc14553e883a418

Author: Zack Rusin <[email protected]>
Date:   Tue Mar 30 08:55:17 2010 -0400

gallivm: cleanup the code (found by coverity)

the condition can't be false, declerations are ok even if we don't
emit any.

---

 src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c |   12 +-----------
 1 files changed, 1 insertions(+), 11 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c 
b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index 95cd6a0..8901e65 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
@@ -666,30 +666,20 @@ emit_declaration(
                              first_inst);
 
    for (idx = first; idx <= last; ++idx) {
-      boolean ok;
-
       switch (decl->Declaration.File) {
       case TGSI_FILE_TEMPORARY:
          for (i = 0; i < NUM_CHANNELS; i++)
             bld->temps[idx][i] = lp_build_alloca(&bld->base);
-         ok = TRUE;
          break;
 
       case TGSI_FILE_OUTPUT:
          for (i = 0; i < NUM_CHANNELS; i++)
             bld->outputs[idx][i] = lp_build_alloca(&bld->base);
-         ok = TRUE;
          break;
 
       default:
          /* don't need to declare other vars */
-         ok = TRUE;
-      }
-
-      if (!ok) {
-         LLVMPositionBuilderAtEnd(bld->base.builder,
-                                  current_block);
-         return FALSE;
+         break;
       }
    }
 

_______________________________________________
mesa-commit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to