Module: Mesa
Branch: master
Commit: 20a78b68a3271d7a66fdf1e55c5882b8c12dfb8d
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=20a78b68a3271d7a66fdf1e55c5882b8c12dfb8d

Author: Marek Olšák <[email protected]>
Date:   Sat Feb 12 03:04:21 2011 +0100

u_vbuf_mgr: fix segfault

max_index could have been less than min_index, which later caused integer
underflow followed by a segfault in memcpy.

---

 src/gallium/auxiliary/util/u_vbuf_mgr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_vbuf_mgr.c 
b/src/gallium/auxiliary/util/u_vbuf_mgr.c
index ca3b4dc..5f5a554 100644
--- a/src/gallium/auxiliary/util/u_vbuf_mgr.c
+++ b/src/gallium/auxiliary/util/u_vbuf_mgr.c
@@ -562,7 +562,7 @@ void u_vbuf_mgr_draw_begin(struct u_vbuf_mgr *mgrb,
    int min_index, max_index;
 
    min_index = info->min_index - info->index_bias;
-   max_index = MIN2(info->max_index, mgr->b.max_index) - info->index_bias;
+   max_index = info->max_index - info->index_bias;
 
    /* Translate vertices with non-native layouts or formats. */
    if (mgr->incompatible_vb_layout || mgr->ve->incompatible_layout) {

_______________________________________________
mesa-commit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to