Module: Mesa
Branch: master
Commit: 85a9a7f09c117cf09d7ab7034ad107365f17d4f2
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=85a9a7f09c117cf09d7ab7034ad107365f17d4f2

Author: Vinson Lee <[email protected]>
Date:   Thu Feb  7 22:46:43 2013 -0800

glsl: Ensure glsl_type constructors initialize gl_type.

Fixes uninitialized scalar field defects reported by Coverity.

Signed-off-by: Vinson Lee <[email protected]>
Reviewed-by: Brian Paul <[email protected]>

---

 src/glsl/glsl_types.cpp |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp
index 4a2c879..3b066d0 100644
--- a/src/glsl/glsl_types.cpp
+++ b/src/glsl/glsl_types.cpp
@@ -81,6 +81,7 @@ glsl_type::glsl_type(GLenum gl_type,
 
 glsl_type::glsl_type(const glsl_struct_field *fields, unsigned num_fields,
                     const char *name) :
+   gl_type(0),
    base_type(GLSL_TYPE_STRUCT),
    sampler_dimensionality(0), sampler_shadow(0), sampler_array(0),
    sampler_type(0), interface_packing(0),
@@ -103,6 +104,7 @@ glsl_type::glsl_type(const glsl_struct_field *fields, 
unsigned num_fields,
 
 glsl_type::glsl_type(const glsl_struct_field *fields, unsigned num_fields,
                     enum glsl_interface_packing packing, const char *name) :
+   gl_type(0),
    base_type(GLSL_TYPE_INTERFACE),
    sampler_dimensionality(0), sampler_shadow(0), sampler_array(0),
    sampler_type(0), interface_packing((unsigned) packing),

_______________________________________________
mesa-commit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to