Module: Mesa
Branch: master
Commit: ce316f62efa208b1a43fe81831126fc75c5807c5
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce316f62efa208b1a43fe81831126fc75c5807c5
Author: Eric Anholt <e...@anholt.net>
Date: Tue Mar 19 17:36:10 2013 -0700
i965/fs: Don't double-emit SEND dependency workarounds at control flow.
We weren't setting needs_dep[i] in the loops, so we'd continue on to
potentially add the same workaround MOVs to the later basic block
boundaries, too. We can either set needs_dep[i] to exit through the
normal path, or we can just return since we know we're done.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 84e88b1..cc8882b 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -2341,6 +2341,7 @@
fs_visitor::insert_gen4_pre_send_dependency_workarounds(fs_inst *inst)
inst->insert_before(DEP_RESOLVE_MOV(first_write_grf + i));
}
}
+ return;
}
bool scan_inst_16wide = (dispatch_width > 8 &&
@@ -2410,6 +2411,7 @@
fs_visitor::insert_gen4_post_send_dependency_workarounds(fs_inst *inst)
if (needs_dep[i])
scan_inst->insert_before(DEP_RESOLVE_MOV(first_write_grf + i));
}
+ return;
}
/* Clear the flag for registers that actually got read (as expected). */
_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-commit
