Module: Mesa Branch: master Commit: 2d9fea95e8627e7524bc4263bc6f9067fcf4db5e URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2d9fea95e8627e7524bc4263bc6f9067fcf4db5e
Author: Roland Scheidegger <[email protected]> Date: Sat Aug 3 00:24:29 2013 +0200 gallivm: fix comment wrt srgb accuracy. I think it's actually not good enough now... --- src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c b/src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c index 848d6f8..2b1fe64 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c @@ -242,8 +242,10 @@ lp_build_linear_to_srgb(struct gallivm_state *gallivm, * error metric if you'd want to tweak them, they also MUST fit with * the crappy polynomial above for srgb->linear since it is required * that each srgb value maps back to the same value). - * This function has an error of max +-0.17 (and we'd only require +-0.6), - * for the approximated srgb->linear values the error is naturally larger + * This function has an error of max +-0.17. Not sure this is actually + * enough, we require +-0.6 but that may include the +-0.5 from integer + * conversion. Seems to pass all relevant tests though... + * For the approximated srgb->linear values the error is naturally larger * (+-0.42) but still accurate enough (required +-0.5 essentially). * All in all (including min/max clamp, conversion) 15 instructions. * FMA would help (minus 2 instructions). _______________________________________________ mesa-commit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-commit
