Module: Mesa
Branch: 9.2
Commit: c088c24588365524f0106936f3d521c9866d9f95
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c088c24588365524f0106936f3d521c9866d9f95

Author: Tapani Pälli <[email protected]>
Date:   Fri Jul 26 10:21:56 2013 +0300

glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

Patch fixes a crash with Webgl 'shader-with-non-reserved-words'
conformance test by ignoring desktop extension keywords on GLSL ES.

v2: fix reserved and allowed desktop glsl versions (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64087
Signed-off-by: Tapani Pälli <[email protected]>
Reviewed-by: Chris Forbes <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
(cherry picked from commit 8c211dd742669bc03b44186e41e5aa40081d6bcc)

---

 src/glsl/glsl_lexer.ll |   29 +++++------------------------
 1 files changed, 5 insertions(+), 24 deletions(-)

diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll
index 6c5d003..3340c23 100644
--- a/src/glsl/glsl_lexer.ll
+++ b/src/glsl/glsl_lexer.ll
@@ -324,30 +324,11 @@ sampler2DMSArray   KEYWORD_WITH_ALT(150, 300, 150, 0, 
yyextra->ARB_texture_multi
 isampler2DMSArray  KEYWORD_WITH_ALT(150, 300, 150, 0, 
yyextra->ARB_texture_multisample_enable, ISAMPLER2DMSARRAY);
 usampler2DMSArray  KEYWORD_WITH_ALT(150, 300, 150, 0, 
yyextra->ARB_texture_multisample_enable, USAMPLER2DMSARRAY);
 
-samplerCubeArray       {
-                         if (yyextra->ARB_texture_cube_map_array_enable)
-                            return SAMPLERCUBEARRAY;
-                         else
-                            return IDENTIFIER;
-               }
-isamplerCubeArray      {
-                         if (yyextra->ARB_texture_cube_map_array_enable)
-                            return ISAMPLERCUBEARRAY;
-                         else
-                            return IDENTIFIER;
-               }
-usamplerCubeArray      {
-                         if (yyextra->ARB_texture_cube_map_array_enable)
-                            return USAMPLERCUBEARRAY;
-                         else
-                            return IDENTIFIER;
-               }
-samplerCubeArrayShadow {
-                         if (yyextra->ARB_texture_cube_map_array_enable)
-                            return SAMPLERCUBEARRAYSHADOW;
-                         else
-                            return IDENTIFIER;
-               }
+   /* keywords available with ARB_texture_cube_map_array_enable extension on 
desktop GLSL */
+samplerCubeArray   KEYWORD_WITH_ALT(400, 0, 400, 0, 
yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAY);
+isamplerCubeArray KEYWORD_WITH_ALT(400, 0, 400, 0, 
yyextra->ARB_texture_cube_map_array_enable, ISAMPLERCUBEARRAY);
+usamplerCubeArray KEYWORD_WITH_ALT(400, 0, 400, 0, 
yyextra->ARB_texture_cube_map_array_enable, USAMPLERCUBEARRAY);
+samplerCubeArrayShadow   KEYWORD_WITH_ALT(400, 0, 400, 0, 
yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAYSHADOW);
 
 samplerExternalOES             {
                          if (yyextra->OES_EGL_image_external_enable)

_______________________________________________
mesa-commit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to