Module: Mesa Branch: master Commit: 30a915bd174a4a4dd950870eca19dde45bbd524b URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=30a915bd174a4a4dd950870eca19dde45bbd524b
Author: Rob Clark <[email protected]> Date: Thu Sep 3 14:53:03 2015 -0400 gallium/docs: clairify dmabuf fd ownership Since debugging issues w/ fd's close()d at the wrong time can be quite fun, this should probably be made more explicit in the docs. Signed-off-by: Rob Clark <[email protected]> --- src/gallium/include/pipe/p_screen.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index a7b7b72..a22fb93 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_screen.h @@ -173,6 +173,10 @@ struct pipe_screen { * Create a texture from a winsys_handle. The handle is often created in * another process by first creating a pipe texture and then calling * resource_get_handle. + * + * NOTE: in the case of DRM_API_HANDLE_TYPE_FD handles, the caller + * retains ownership of the FD. (This is consistent with + * EGL_EXT_image_dma_buf_import) */ struct pipe_resource * (*resource_from_handle)(struct pipe_screen *, const struct pipe_resource *templat, @@ -190,6 +194,10 @@ struct pipe_screen { * Get a winsys_handle from a texture. Some platforms/winsys requires * that the texture is created with a special usage flag like * DISPLAYTARGET or PRIMARY. + * + * NOTE: in the case of DRM_API_HANDLE_TYPE_FD handles, the caller + * takes ownership of the FD. (This is consistent with + * EGL_MESA_image_dma_buf_export) */ boolean (*resource_get_handle)(struct pipe_screen *, struct pipe_resource *tex, _______________________________________________ mesa-commit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-commit
