Module: Mesa Branch: master Commit: 975b1299dd495a910bcfb86e3dc24131ed3c2e2f URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=975b1299dd495a910bcfb86e3dc24131ed3c2e2f
Author: Kenneth Graunke <[email protected]> Date: Mon Nov 30 01:54:42 2015 -0800 i965: Increase BRW_MAX_UBO to 14. The NVIDIA binary driver and Intel's closed source driver both expose 14 here, rather than the GL minimum of 12. Let's follow suit. Without this, Shadow of Mordor fails to render correctly and triggers OpenGL errors: Mesa: User error: GL_INVALID_VALUE in glBindBufferBase(index=68) Mesa: User error: GL_INVALID_VALUE in glUniformBlockBinding(block binding 68 >= 60) There are 5 stages (VS, TCS, TES, GS, FS), and 12 * 5 = 60 is too small. 14 * 5 = 70 will work just fine. Tapani believes this will also help Alien Isolation. Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Jordan Justen <[email protected]> Acked-by: Tapani Pälli <[email protected]> Acked-by: Matt Turner <[email protected]> --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index e45df46..bfd202f 100644 --- a/src/mesa/drivers/dri/i965/brw_context.h +++ b/src/mesa/drivers/dri/i965/brw_context.h @@ -414,7 +414,7 @@ struct brw_ff_gs_prog_data { #define BRW_MAX_DRAW_BUFFERS 8 /** Max number of UBOs in a shader */ -#define BRW_MAX_UBO 12 +#define BRW_MAX_UBO 14 /** Max number of SSBOs in a shader */ #define BRW_MAX_SSBO 12 _______________________________________________ mesa-commit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-commit
