Module: Mesa
Branch: master
Commit: abc7b110b6f6dbd00db3633a68cc836170465d91
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=abc7b110b6f6dbd00db3633a68cc836170465d91

Author: Constantine Charlamov <[email protected]>
Date:   Sat Jun 24 15:52:05 2017 +0300

r600g: fix crash when file in R600_TRACE doesn't exist

…and print error in such case. Which probably is not a rare event btw
because fopen doesn't expand ~ to $HOME.

Also get rid of unused "bool ret" variable.

Signed-off-by: Constantine Kharlamov <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>

---

 src/gallium/drivers/r600/r600_hw_context.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/r600/r600_hw_context.c 
b/src/gallium/drivers/r600/r600_hw_context.c
index 9b01e8e7d5..ca7f41db68 100644
--- a/src/gallium/drivers/r600/r600_hw_context.c
+++ b/src/gallium/drivers/r600/r600_hw_context.c
@@ -295,15 +295,16 @@ void r600_context_gfx_flush(void *context, unsigned flags,
        ctx->b.num_gfx_cs_flushes++;
 
        if (ctx->is_debug) {
-               bool ret = ws->fence_wait(ws, ctx->b.last_gfx_fence, 10000000);
-               if (ret == false) {
+               if (!ws->fence_wait(ws, ctx->b.last_gfx_fence, 10000000)) {
                        const char *fname = getenv("R600_TRACE");
                        if (!fname)
                                exit(-1);
                        FILE *fl = fopen(fname, "w+");
-                       if (fl)
+                       if (fl) {
                                eg_dump_debug_state(&ctx->b.b, fl, 0);
-                       fclose(fl);
+                               fclose(fl);
+                       } else
+                               perror(fname);
                        exit(-1);
                }
        }

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to