Module: Mesa Branch: master Commit: b8dd69e1b49a5c4c5c82e34f804a97f7448ff6c3 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8dd69e1b49a5c4c5c82e34f804a97f7448ff6c3
Author: Grazvydas Ignotas <[email protected]> Date: Mon Aug 28 00:29:36 2017 +0300 radv: don't assert on empty hash table Currently if table_size is 0, it's falling through to: unreachable("hash table should never be full"); But table_size can be 0 when RADV_DEBUG=nocache is set, or when the table allocation fails (which is not considered an error). Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" Signed-off-by: Grazvydas Ignotas <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> --- src/amd/vulkan/radv_pipeline_cache.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c index 99a614dc10..beed35b53a 100644 --- a/src/amd/vulkan/radv_pipeline_cache.c +++ b/src/amd/vulkan/radv_pipeline_cache.c @@ -118,6 +118,9 @@ radv_pipeline_cache_search_unlocked(struct radv_pipeline_cache *cache, const uint32_t mask = cache->table_size - 1; const uint32_t start = (*(uint32_t *) sha1); + if (cache->table_size == 0) + return NULL; + for (uint32_t i = 0; i < cache->table_size; i++) { const uint32_t index = (start + i) & mask; struct cache_entry *entry = cache->hash_table[index]; _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
