Module: Mesa
Branch: master
Commit: d1245211417c092bd1c12339559caced98d7560f
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d1245211417c092bd1c12339559caced98d7560f

Author: Kenneth Graunke <[email protected]>
Date:   Wed Aug 30 00:54:40 2017 -0700

i965: Delete a batch size assertion that isn't very useful.

This assertion prevents you from doing intel_batchbuffer_require_space
with a size so huge it won't fit in the batchbuffer.  This doesn't seem
like a common mistake, and I've never seen the assert to be useful.

Soon, I hope to have batches grow, at which point this won't make sense.

Reviewed-by: Matt Turner <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>

---

 src/mesa/drivers/dri/i965/intel_batchbuffer.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c 
b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 515b595bc9..cd118f6c6f 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -238,9 +238,6 @@ intel_batchbuffer_require_space(struct brw_context *brw, 
GLuint sz,
       intel_batchbuffer_flush(brw);
    }
 
-#ifdef DEBUG
-   assert(sz < BATCH_SZ - BATCH_RESERVED);
-#endif
    if (intel_batchbuffer_space(&brw->batch) < sz)
       intel_batchbuffer_flush(brw);
 

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to