Module: Mesa Branch: master Commit: 0084f4a42290ab54c185c9284a5670d4da4fc66e URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0084f4a42290ab54c185c9284a5670d4da4fc66e
Author: Dave Airlie <airl...@redhat.com> Date: Tue Oct 31 11:29:54 2017 +1000 ac/nir: for ubo load use correct num_components I was hacking something stupid in doom, and hit an assert for the bitcast following this, it definitely looks like this should be the number of 32-bit components, not the instr level ones. Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 38a65b9cd1..2ae656693f 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -2467,7 +2467,7 @@ static LLVMValueRef visit_load_ubo_buffer(struct ac_nir_context *ctx, } - ret = ac_build_gather_values(&ctx->ac, results, instr->num_components); + ret = ac_build_gather_values(&ctx->ac, results, num_components); return LLVMBuildBitCast(ctx->ac.builder, ret, get_def_type(ctx, &instr->dest.ssa), ""); } _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-commit