Module: Mesa
Branch: 17.3
Commit: 383b3603482616765e0716fd42a0698772b36d0f
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=383b3603482616765e0716fd42a0698772b36d0f

Author: Jason Ekstrand <[email protected]>
Date:   Wed Nov  1 07:57:21 2017 -0700

intel/fs: Alloc pull constants off mem_ctx

It doesn't actually matter since the only user of push constants, i965,
ralloc_steals it back to NULL but it's more consistent and probably
fixes memory leaks in some error cases.

Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Tapani Pälli <[email protected]>
Cc: [email protected]
(cherry picked from commit 7b4387519c382cffef9c62bbbbefcfe71cfde905)

---

 src/intel/compiler/brw_fs.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index e546792255..21ff030908 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -2095,7 +2095,7 @@ fs_visitor::assign_constant_locations()
    stage_prog_data->param = ralloc_array(mem_ctx, uint32_t, 
num_push_constants);
    if (num_pull_constants > 0) {
       stage_prog_data->nr_pull_params = num_pull_constants;
-      stage_prog_data->pull_param = ralloc_array(NULL, uint32_t,
+      stage_prog_data->pull_param = ralloc_array(mem_ctx, uint32_t,
                                                  num_pull_constants);
    }
 

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to