Module: Mesa
Branch: master
Commit: 272e7e1bd5c12a3ef36027f0071065b7ce04e9e9
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=272e7e1bd5c12a3ef36027f0071065b7ce04e9e9

Author: Roland Scheidegger <srol...@vmware.com>
Date:   Tue Jan 30 01:03:49 2018 +0100

mesa: (trivial) add TODO comment for default results for internal queries

---

 src/mesa/main/formatquery.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
index 9174fb6b27..1846fbc688 100644
--- a/src/mesa/main/formatquery.c
+++ b/src/mesa/main/formatquery.c
@@ -700,6 +700,12 @@ _mesa_query_internal_format_default(struct gl_context 
*ctx, GLenum target,
    case GL_FRAMEBUFFER_RENDERABLE_LAYERED:
    case GL_FRAMEBUFFER_BLEND:
    case GL_FILTER:
+      /*
+       * TODO seems a tad optimistic just saying yes to everything here.
+       * Even for combinations which make no sense...
+       * And things like TESS_CONTROL_TEXTURE should definitely default to
+       * NONE if the driver doesn't even support tessellation...
+       */
       params[0] = GL_FULL_SUPPORT;
       break;
    case GL_NUM_TILING_TYPES_EXT:

_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to