Module: Mesa Branch: master Commit: 94843e60562c52975325f59f21cb1c8e89f2fe20 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94843e60562c52975325f59f21cb1c8e89f2fe20
Author: Brian Paul <[email protected]> Date: Mon Jan 29 14:19:44 2018 -0700 mesa: fix incorrect size/error test in _mesa_GetUnsignedBytevEXT() get_value_size() returns -1 for an error. The similar check in _mesa_GetUnsignedBytei_vEXT() is correct. Found by chance. There are apparently no Piglit tests which exercise glGetUnsignedBytei_vEXT() or glGetUnsignedBytevEXT(). Reviewed-by: Andres Rodriguez <[email protected]> Reviewed-by: Marek Olšák <[email protected]> --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 5fee9a60bc..bafd1e35b2 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -2064,7 +2064,7 @@ _mesa_GetUnsignedBytevEXT(GLenum pname, GLubyte *data) d = find_value(func, pname, &p, &v); size = get_value_size(d->type, &v); - if (size >= 0) { + if (size <= 0) { _mesa_problem(ctx, "invalid value type in GetUnsignedBytevEXT()"); } _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
