Module: Mesa
Branch: master
Commit: a4f1fc5dd197a0cd107b6a96a222ace4105680dd
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a4f1fc5dd197a0cd107b6a96a222ace4105680dd

Author: Dylan Baker <[email protected]>
Date:   Mon Nov 20 10:05:25 2017 -0800

glapi/check_table: Remove 'extern "C"' block

Using 'extern "C"' around includes is always incorrect, as the header may
contain C++ symbols (as it does in this case), which means it cannot use
C linkage. In this case the header has a template in it, which obviously
cannot be linked with C linkage rules.

Fixes: a29ad2b421b75a1727b ("mesa/tests: Add tests for the generated dispatch 
table")
Signed-off-by: Dylan Baker <[email protected]>
Reviewed-by: Eric Engestrom <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>

---

 src/mapi/glapi/tests/check_table.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mapi/glapi/tests/check_table.cpp 
b/src/mapi/glapi/tests/check_table.cpp
index 62b3a43d22..7cded8d352 100644
--- a/src/mapi/glapi/tests/check_table.cpp
+++ b/src/mapi/glapi/tests/check_table.cpp
@@ -24,10 +24,8 @@
 #include <gtest/gtest.h>
 #include "main/glheader.h"
 
-extern "C" {
 #include "glapi/glapi.h"
 #include "glapi/glapitable.h"
-}
 
 struct name_offset {
    const char *name;

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to