Module: Mesa Branch: staging/18.1 Commit: 695a5159752747d35191e431f359f836b819e598 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=695a5159752747d35191e431f359f836b819e598
Author: Emil Velikov <[email protected]> Date: Mon Jan 22 17:52:49 2018 +0000 swr: don't export swr_create_screen_internal With earlier rework the user and provider of the symbol are within the same binary. Thus there's no point in exporting the function. Spotted while reviewing patch from Chuck, that nearly added another unneeded PUBLIC function. Cc: Chuck Atkins <[email protected]> Cc: Tim Rowley <[email protected]> Fixes: f50aa21456d "(swr: build driver proper separate from rasterizer") Signed-off-by: Emil Velikov <[email protected]> Tested-by: Chuck Atkins <[email protected]> Reviewed-By: George Kyriazis <[email protected]<mailto:[email protected]>> Tested-by: Chuck Atkins <[email protected]<mailto:[email protected]>> (cherry picked from commit 54d844897fe0afea4b5ddf08565af49a8191d808) --- src/gallium/drivers/swr/swr_public.h | 2 +- src/gallium/drivers/swr/swr_screen.cpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_public.h b/src/gallium/drivers/swr/swr_public.h index 07ea6280cd..b32f41fdf7 100644 --- a/src/gallium/drivers/swr/swr_public.h +++ b/src/gallium/drivers/swr/swr_public.h @@ -37,7 +37,7 @@ extern "C" { struct pipe_screen *swr_create_screen(struct sw_winsys *winsys); // arch-specific dll entry point -PUBLIC struct pipe_screen *swr_create_screen_internal(struct sw_winsys *winsys); +struct pipe_screen *swr_create_screen_internal(struct sw_winsys *winsys); // cleanup for failed screen creation void swr_destroy_screen_internal(struct swr_screen **screen); diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp index 4e43ac55fb..bf71683caf 100644 --- a/src/gallium/drivers/swr/swr_screen.cpp +++ b/src/gallium/drivers/swr/swr_screen.cpp @@ -1125,7 +1125,6 @@ swr_validate_env_options(struct swr_screen *screen) } -PUBLIC struct pipe_screen * swr_create_screen_internal(struct sw_winsys *winsys) { _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
