URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd6303a4400781c3ac020d2b9846574467ad6589
Author: Jason Ekstrand <[email protected]>
Date: Tue Aug 21 20:43:57 2018 -0500
anv: Clamp scissors to the framebuffer boundary
The Vulkan 1.1.81 spec says:
"It is legal for offset.x + extent.width or offset.y + extent.height
to exceed the dimensions of the framebuffer - the scissor test still
applies as defined above. Rasterization does not produce fragments
outside of the framebuffer, so such fragments never have the scissor
test performed on them."
Elsewhere, the Vulkan 1.1.81 spec says:
"The application must ensure (using scissor if necessary) that all
rendering is contained within the render area, otherwise the pixels
outside of the render area become undefined and shader side effects
may occur for fragments outside the render area. The render area
must be contained within the framebuffer dimensions."
Unfortunately, there's some room for interpretation here as to what the
consequences are of having the render area set to exactly the
framebuffer dimensions and having a scissor that is larger than the
framebuffer. Given that GL and other APIs provide automatic clipping to
the framebuffer, it makes sense that applications would assume that
Vulkan does this as well. It costs us very little to play it safe and
just clamp client-provided scissors to the framebuffer dimensions.
Fortunately, the user is required to provide us with at least one
scissor so we don't need to handle the case where they don't.
Fixes: fb2a5ceb3264 "anv: Emit DRAWING_RECTANGLE once at driver..."
Reviewed-by: Kenneth Graunke <[email protected]>
(cherry picked from commit 465e5a868cd58ca7c4ff7476e98231ffd4f3d2bf)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ded225eb9870ef7ab3c60de2876daeb3d0168c41
Author: Eric Anholt <[email protected]>
Date: Fri Aug 24 15:45:37 2018 -0700
v3d: Fix setup of the VCM cache size.
There were two bugs working together to make things mostly work: I wasn't
dividing the VPM output size available by the size of a batch (vertex),
but I also had the size of the VPM reduced by a factor of 8.
Fixes dEQP-GLES3.functional.vertex_array_objects.all_attributes and it
seems also my intermittent varying failures.
Fixes: 1561e4984eb0 ("v3d: Emit the VCM_CACHE_SIZE packet.")
(cherry picked from commit a91b158bd9e1b6bc08f1d5ac350cd8b68e372042)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f20c0a004e3e8ed4f56114af445ac9eed9e19e6
Author: Sergii Romantsov <[email protected]>
Date: Thu Sep 6 12:59:47 2018 +0300
i965/tools: 32bit compilation with meson
Building of 32bit mesa with meson causes issue:
"implicit declaration of function ‘__builtin_ia32_clflush’".
Fixed by adding msse2 compilation flag.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843
Fixes: 314879f7fec0 (i965: Fix asynchronous mappings on !LLC platforms.)
Signed-off-by: Sergii Romantsov <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]>
(cherry picked from commit 97fcccb25ed5f55139c03ebc1c71742f0f25f683)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <[email protected]>
Conflicts:
src/intel/tools/meson.build
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5333eba63a9a515fb02c0f9b249cf53e86c941d9
Author: Jason Ekstrand <[email protected]>
Date: Tue Aug 21 20:40:50 2018 -0500
anv: Disable the vertex cache when tessellating on SKL GT4
I have no idea if I'm correct about what's going wrong or if this is the
correct fix. However, in my multiple weeks of banging my head on this
hang, a VUE reference counting bug seems to match all the symptoms and
it definitely fixes the hang.
Cc: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107280
Reviewed-by: Kenneth Graunke <[email protected]>
(cherry picked from commit b08b4b2b25b201df2d667cf70d7f99475e5c7aec)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9909102335294670952ff507d1448f2da4b43cb3
Author: Jason Ekstrand <[email protected]>
Date: Tue Aug 21 17:14:38 2018 -0500
anv: Re-emit vertex buffers when the pipeline changes
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance
data step rate, and pitch come from the pipeline.
Cc: [email protected]
Reviewed-by: Kenneth Graunke <[email protected]>
(cherry picked from commit c643c5e18d7c647afc6dcc450183b81a62a40998)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=320dd62ce18375244b73c1a9e386461f569549b9
Author: Jason Ekstrand <[email protected]>
Date: Fri Sep 7 00:40:54 2018 -0500
i965: Workaround the gen9 hw astc5x5 sampler bug
gen9 hardware has a bug in the sampler cache that can cause GPU hangs
whenever an texture with aux compression enabled is in the sampler cache
together with an ASTC5x5 texture. Because we can't control what the
client binds at any given time, we have two options: resolve the CCS or
decompresss the ASTC. Doing a CCS or HiZ resolve is far less drastic
and will likely have a smaller performance impact.
Cc: [email protected]
Reviewed-by: Kristian H. Kristensen <[email protected]>
Tested-by: Tapani Pälli <[email protected]>
Reviewed-by: Topi Pohjolainen <[email protected]>
(cherry picked from commit f9e630e23dfa3de815026a08e7e767e2ed90da0b)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ed365a7fffde6cd17889d708b17f66a4a9509eb
Author: Eric Anholt <[email protected]>
Date: Thu Sep 6 13:37:37 2018 -0700
v3d: Fix SRC_ALPHA_SATURATE blending for RTs without alpha.
Fixes
dEQP-GLES3.functional.fragment_ops.blend.default_framebuffer.rgb_func_alpha_func.dst.src_alpha_saturate_src_alpha_saturate
and friends with --deqp-egl-config-name=rgb565d0s0
Cc: "18.2" <[email protected]>
(cherry picked from commit f73f748323ef5a421ffd8fa0f02afd9627e31023)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9dff29fda5376acf2315848cf054e986a6ba6247
Author: Sergii Romantsov <[email protected]>
Date: Thu Sep 6 11:07:45 2018 +0300
intel: compiler option msse2 and mstackrealign
Seems in case of 32-bit library, usage of msse2 makes
some stack corruption or incorrect instructions.
Usage with mstackrealign fixes that case.
v2: Fixed meson.
v3: Definition of c_sse2_args moved on the top (L.Landwerlin).
Added mstackrealign for Android's mks where msee4.1 is used.
v4: Added for Vulkan also.
v5: Commit message correction.
CC: <[email protected]>
Fixes: 6b05c080f202 (i965: Compile with -msse3)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779
Signed-off-by: Sergii Romantsov <[email protected]>
Reviewed-by: Dylan Baker <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]>
(cherry picked from commit d709f127927cb0ad40d5bf4eaec33c3c27f7738a)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ca64c687298af75aba08d2808c70432f8582351
Author: Andres Gomez <[email protected]>
Date: Fri Sep 7 02:47:23 2018 +0300
cherry-ignore: i965/tools: 32bit compilation with meson
fixes: This commit was immediately reverted by commit 2dce1175c1c.
Signed-off-by: Andres Gomez <[email protected]>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4c977744ba3f99cd0c71773c684a3247af4ba98a
Author: Andres Gomez <[email protected]>
Date: Sat Sep 8 01:03:13 2018 +0300
Revert "Revert "glsl: skip stringification in preprocessor if in
unreachable branch""
This reverts commit 2fd6f06faabb5b16d529e035ae4523a8566bf9bc.
Take back 28a3731e3f4 ("glsl: skip stringification in preprocessor if in
unreachable branch") after b9fe8ff23dc ("glsl: fixer lexer for
unreachable defines") has made it to the branch.
Signed-off-by: Andres Gomez <[email protected]>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a471fe120f408bc2e016246e6416b6321739158
Author: Timothy Arceri <[email protected]>
Date: Sat Sep 1 23:57:38 2018 +1000
glsl: fixer lexer for unreachable defines
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define itself is so
this then gets recognised as #if.
Until 28a3731e3f this didn't happen because we ended up in
<HASH>{NONSPACE} where BEGIN INITIAL was called stopping the
problem from happening.
This change makes sure we never call RETURN_TOKEN_NEVER_SKIP for
if/else/endif when processing a define.
Cc: Ian Romanick <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
Tested-By: Eero Tamminen <[email protected]>
Reviewed-by: Ian Romanick <[email protected]>
(cherry picked from commit b9fe8ff23dcfe4956be1eac4de0838d4a3720315)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ddc689d6815db8d226897b9037378fca753f8aa
Author: Andrii Simiklit <[email protected]>
Date: Thu Sep 6 17:43:54 2018 +0300
mesa/util: add missing va_end() after va_copy()
MSDN:
"va_end must be called on each argument list that's initialized
with va_start or va_copy before the function returns."
Reviewed-by: Eric Engestrom <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810
Fixes: c6267ebd6c8a "gallium/util: Stop bundling our snprintf
implementation."
Signed-off-by: Andrii Simiklit <[email protected]>
(cherry picked from commit 2930b76cfe1e13e84ac0d88f9c6d709a5a8d4c18)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=841dc893ca67fe2d35fb2831d48556beb14ee454
Author: Andrii Simiklit <[email protected]>
Date: Thu Sep 6 17:43:53 2018 +0300
mesa/util: don't ignore NULL returned from 'malloc'
We should exit from the function 'util_vasprintf'
with error code -1 for case where 'malloc'
returns NULL
Reviewed-by: Eric Engestrom <[email protected]>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <[email protected]>
(cherry picked from commit 65cfe698b0f4ba412198d212c14481a60c1b8389)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d55da359fa06f5b345273a02a4e6b23f82721bb1
Author: Andrii Simiklit <[email protected]>
Date: Thu Sep 6 17:43:52 2018 +0300
mesa/util: don't use the same 'va_list' instance twice
The first usage of the 'va_list' instance could change it.
Reviewed-by: Eric Engestrom <[email protected]>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <[email protected]>
(cherry picked from commit 570cacba7af165175ad40820c5e663db5b1c5066)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e1695569dea2387367e5cd333cf6fc1262e558a7
Author: Andrii Simiklit <[email protected]>
Date: Thu Sep 6 17:43:51 2018 +0300
apple/glx/log: added missing va_end() after va_copy()
Each invocation of va_copy() must be matched by a
corresponding invocation of va_end()
Reviewed-by: Eric Engestrom <[email protected]>
Fixes: 51691f0767f6 "darwin: Use ASL for logging"
Signed-off-by: Andrii Simiklit <[email protected]>
(cherry picked from commit 267ed29288db478a47d180bd1370a4df60ddb3ef)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=884fa138655ab6d7938e4a5e947a243cc2852a60
Author: Mathias Fröhlich <[email protected]>
Date: Fri Aug 10 11:37:43 2018 +0200
tnl: Fix green gun regression in xonotic.
Fix an other regression of
mesa: Make gl_vertex_array contain pointers to first order VAO members.
The regression showed up with drivers using the tnl module and
was reproducible using xonotic-glx -benchmark demos/the-big-keybench.dem.
Fixes: 64d2a204805
mesa: Make gl_vertex_array contain pointers to first order VAO members.
Tested-by: Ville Syrjälä <[email protected]>
Reviewed-by: Ian Romanick <[email protected]>
Signed-off-by: Mathias Fröhlich <[email protected]>
(cherry picked from commit a6232b69321b465e9733a4b207088d923b75e714)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=432a95b65f29c068bd33d548f1bef271694e4231
Author: Jason Ekstrand <[email protected]>
Date: Tue Sep 4 13:58:01 2018 -0500
anv/pipeline: Only consider double elements which actually exist
The brw_vs_prog_data::double_inputs_read field comes directly from
shader_info::double_inputs which may contain inputs which are not
actually read. Instead of using it directly, AND it with inputs_read
which is only things which are read. Otherwise, we may end up
subtracting too many elements when computing elem_count.
Cc: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103241
Reviewed-by: Lionel Landwerlin <[email protected]>
(cherry picked from commit 7b26741806c521279a1b83f2eae40a277d806626)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=93726c17c68f64c415962ea1f6234c673d3c1435
Author: Dylan Baker <[email protected]>
Date: Tue Sep 4 14:42:07 2018 -0700
meson: Print a message about why a libdrm version was selected
We require a single version of libdrm for all of our libdrm
dependencies (core and driver), but the way this is structured can make
the error message less than helpful, as one driver might be the one
setting the libdrm requirement, while another might be the one that
generates the version failure.
This adds a simple message to the output announcing which libdrm module
set the version, which might be more helpful.
v2: - Use message suggested by Eric Engstrom
Fixes: c445b1d56f47922206de55e557444aadb62e11f6
("meson: Use the same version for all libdrm checks")
Reviewed-by: Eric Engestrom <[email protected]>
(cherry picked from commit d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb41d6e95c40e024b2dc1339e44a004061606837
Author: Gert Wollny <[email protected]>
Date: Mon Sep 3 10:05:44 2018 +0200
winsys/virgl: correct resource and handle allocation (v2)
Fixes crash with
piglit/bin/map_buffer_range-invalidate CopyBufferSubData \
increment-offset -auto -fbo
* Resize the resource storage already when the count is equal to the
allocated size, fixes:
Invalid write of size 8
at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629)
by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd
at 0x4C31B25: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567)
* Also resize the space allocated for the handles, fixes:
Invalid write of size 4
at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631)
by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd
at 0x4C2FB0F: malloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so)
by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572)
Fixes: 4b15b5e803e ("virgl: resize resource bo allocation if we need to.")
v2: - Use REALLOC macro and avoid memory leak when re-allocation fails
- add Fixes tag (both Emil Velikov)
- reorder commit message
Signed-off-by: Gert Wollny <[email protected]>
(cherry picked from commit 9b0e8d87233691c1f025002f1da89ed3f8f69583)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=cb1ddf48e223231fc4e2cfdc92fbcdaec673929d
Author: Andres Gomez <[email protected]>
Date: Sat Sep 8 00:26:57 2018 +0300
docs: add sha256 checksums for 18.2.0
Signed-off-by: Andres Gomez <[email protected]>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=7378180e7aa652f3f95e4b953a552dcaf8fb8408
Author: Andres Gomez <[email protected]>
Date: Sat Sep 8 00:10:22 2018 +0300
docs: update 18.2.0 release notes
Signed-off-by: Andres Gomez <[email protected]>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=83c0910b532af9cc50dd45fdce86680ac5a890c1
Author: Andres Gomez <[email protected]>
Date: Fri Sep 7 19:55:08 2018 +0300
Update version to 18.2.0(final)
Signed-off-by: Andres Gomez <[email protected]>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2fd6f06faabb5b16d529e035ae4523a8566bf9bc
Author: Andres Gomez <[email protected]>
Date: Fri Sep 7 18:22:09 2018 +0300
Revert "glsl: skip stringification in preprocessor if in unreachable branch"
This reverts commit c52bcfa61ca48b530dce1d6bf65113d8d087fccf.
This revealed the bug reported at:
https://bugs.freedesktop.org/show_bug.cgi?id=107772
Signed-off-by: Andres Gomez <[email protected]>
_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
