Module: Mesa Branch: staging/18.3 Commit: 98c0d87acd655314761c1ea607c19fb39fe4acfc URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=98c0d87acd655314761c1ea607c19fb39fe4acfc
Author: Emil Velikov <[email protected]> Date: Thu Nov 8 15:05:15 2018 +0000 bin/get-pick-list.sh: handle "typod" usecase. As the comment in get-typod-pick-list.sh says, there's little point in having a duplicate file. Add the new pattern + tag to get-pick-list.sh and nuke this file. v2: - pass the sha as argument to the function - grep -q instead of using a variable (Eric) Cc: [email protected] Reviewed-by: Juan A. Suarez <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Signed-off-by: Emil Velikov <[email protected]> (cherry picked from commit e6b3a3b2014413366110f6deeced8095e7262b1d) --- bin/get-pick-list.sh | 9 ++++++++- bin/get-typod-pick-list.sh | 42 ------------------------------------------ 2 files changed, 8 insertions(+), 43 deletions(-) diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 2c7d87db0c..2476b593f1 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-pick-list.sh @@ -16,6 +16,11 @@ is_stable_nomination() git show --summary "$1" | grep -q -i -o "CC:.*mesa-stable" } +is_typod_nomination() +{ + git show --summary "$1" | grep -q -i -o "CC:.*mesa-dev" +} + # Use the last branchpoint as our limit for the search latest_branchpoint=`git merge-base origin/master HEAD` @@ -25,7 +30,7 @@ git log --reverse --pretty=medium --grep="cherry picked from commit" $latest_bra sed -e 's/^[[:space:]]*(cherry picked from commit[[:space:]]*//' -e 's/)//' > already_picked # Grep for commits that were marked as a candidate for the stable tree. -git log --reverse --pretty=%H -i --grep='^CC:.*mesa-stable' $latest_branchpoint..origin/master |\ +git log --reverse --pretty=%H -i --grep='^CC:.*mesa-stable\|^CC:.*mesa-dev' $latest_branchpoint..origin/master |\ while read sha do # Check to see whether the patch is on the ignore list. @@ -42,6 +47,8 @@ do if is_stable_nomination "$sha"; then tag=stable + elif is_typod_nomination "$sha"; then + tag=typod else continue fi diff --git a/bin/get-typod-pick-list.sh b/bin/get-typod-pick-list.sh deleted file mode 100755 index eb4181d66b..0000000000 --- a/bin/get-typod-pick-list.sh +++ /dev/null @@ -1,42 +0,0 @@ -#!/bin/sh - -# Script for generating a list of candidates which have typos in the nomination line -# -# Usage examples: -# -# $ bin/get-typod-pick-list.sh -# $ bin/get-typod-pick-list.sh > picklist -# $ bin/get-typod-pick-list.sh | tee picklist - -# NB: -# This script intentionally _never_ checks for specific version tag -# Should we consider folding it with the original get-pick-list.sh - -# Use the last branchpoint as our limit for the search -latest_branchpoint=`git merge-base origin/master HEAD` - -# Grep for commits with "cherry picked from commit" in the commit message. -git log --reverse --grep="cherry picked from commit" $latest_branchpoint..HEAD |\ - grep "cherry picked from commit" |\ - sed -e 's/^[[:space:]]*(cherry picked from commit[[:space:]]*//' -e 's/)//' > already_picked - -# Grep for commits that were marked as a candidate for the stable tree. -git log --reverse --pretty=%H -i --grep='^CC:.*mesa-dev' $latest_branchpoint..origin/master |\ -while read sha -do - # Check to see whether the patch is on the ignore list. - if [ -f bin/.cherry-ignore ] ; then - if grep -q ^$sha bin/.cherry-ignore ; then - continue - fi - fi - - # Check to see if it has already been picked over. - if grep -q ^$sha already_picked ; then - continue - fi - - git log -n1 --pretty=oneline $sha | cat -done - -rm -f already_picked _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
