Module: Mesa Branch: master Commit: 338d399fd01caec7f558bb469517baa318410e06 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=338d399fd01caec7f558bb469517baa318410e06
Author: Eric Anholt <[email protected]> Date: Wed Feb 6 13:32:21 2019 -0800 freedreno: Use the NIR lowering for isign. I think this will save an instruction and hopefully not increase any other costs (possibly the immediate -1 and 1?), but I haven't actually tested. Reviewed-by: Kristian H. Kristensen <[email protected]> --- src/freedreno/ir3/ir3_compiler_nir.c | 14 -------------- src/freedreno/ir3/ir3_nir.c | 1 + 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/src/freedreno/ir3/ir3_compiler_nir.c b/src/freedreno/ir3/ir3_compiler_nir.c index fd64173562..03d8a2c7ba 100644 --- a/src/freedreno/ir3/ir3_compiler_nir.c +++ b/src/freedreno/ir3/ir3_compiler_nir.c @@ -563,20 +563,6 @@ emit_alu(struct ir3_context *ctx, nir_alu_instr *alu) case nir_op_ishr: dst[0] = ir3_ASHR_B(b, src[0], 0, src[1], 0); break; - case nir_op_isign: { - /* maybe this would be sane to lower in nir.. */ - struct ir3_instruction *neg, *pos; - - neg = ir3_CMPS_S(b, src[0], 0, create_immed(b, 0), 0); - neg->cat2.condition = IR3_COND_LT; - - pos = ir3_CMPS_S(b, src[0], 0, create_immed(b, 0), 0); - pos->cat2.condition = IR3_COND_GT; - - dst[0] = ir3_SUB_U(b, pos, 0, neg, 0); - - break; - } case nir_op_isub: dst[0] = ir3_SUB_U(b, src[0], 0, src[1], 0); break; diff --git a/src/freedreno/ir3/ir3_nir.c b/src/freedreno/ir3/ir3_nir.c index d9fcf798b3..5c568bd75c 100644 --- a/src/freedreno/ir3/ir3_nir.c +++ b/src/freedreno/ir3/ir3_nir.c @@ -40,6 +40,7 @@ static const nir_shader_compiler_options options = { .lower_fmod32 = true, .lower_fmod64 = true, .lower_fdiv = true, + .lower_isign = true, .lower_ldexp = true, .fuse_ffma = true, .native_integers = true, _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
