Module: Mesa Branch: master Commit: ebbb05b3c93d8f62985099cc9d4cf157c597f4b5 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ebbb05b3c93d8f62985099cc9d4cf157c597f4b5
Author: Kenneth Graunke <[email protected]> Date: Wed May 1 11:16:13 2019 -0700 iris: Fix imageBuffer and PBO download. Recently we added checks to try and deny multisampled shader images. Unfortunately, this messed up imageBuffers, which have sample_count = 0, which are also used in PBO download, causing us hit CPU map fallbacks. Fixes: b15f5cfd20c iris: Do not advertise multisampled image load/store. Reviewed-by: Rafael Antognolli <[email protected]> --- src/gallium/drivers/iris/iris_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/iris/iris_formats.c b/src/gallium/drivers/iris/iris_formats.c index 1c32f1a6aa1..87bbcbd4069 100644 --- a/src/gallium/drivers/iris/iris_formats.c +++ b/src/gallium/drivers/iris/iris_formats.c @@ -455,9 +455,9 @@ iris_is_format_supported(struct pipe_screen *pscreen, if (usage & PIPE_BIND_SHADER_IMAGE) { /* Dataport doesn't support compression, and we can't resolve an MCS - * compressed surface. + * compressed surface. (Buffer images may have sample count of 0.) */ - supported &= sample_count == 1; + supported &= sample_count <= 1; // XXX: allow untyped reads supported &= isl_format_supports_typed_reads(devinfo, format) && _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
