Module: Mesa Branch: master Commit: 16a1ef7860e4f0ce27faceb6874870d8d6fd5a56 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=16a1ef7860e4f0ce27faceb6874870d8d6fd5a56
Author: Alejandro Piñeiro <[email protected]> Date: Thu May 16 11:32:23 2019 +0200 docs: advice to resolve discussion on gitlab MR doc For newcomers to gitlab, it is not evident that it is better to press the "Resolve Discussion" button when you update your branch handling feedback. v2: * Fix several grammar nits, reorder, use new corrected text (Connor Abbot) * Use "reviewers", instead of reviewer (Eric Engestrom) Reviewed-by: Connor Abbott <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> --- docs/submittingpatches.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 020e73d09ec..48cc6768b46 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -258,6 +258,9 @@ your email administrator for this.) </p> <ul> <li>Make changes and update your branch based on feedback + <li>After an update, for the feedback you handled, close the + feedback discussion with the "Resolve Discussion" button. This way + the reviewers know which feedback got handled and which didn't. <li>Old, stale MR may be closed, but you can reopen it if you still want to pursue the changes <li>You should periodically check to see if your MR needs to be _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
