I've had a look at it and come with more efficient variants of the two
opcodes. Actually, we don't need the native r5xx SGT instruction, not idea
why it exists. See the commit
f0896e7f80c2c00d263b3ecd7bb18dfffa9a01a8<http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0896e7f80c2c00d263b3ecd7bb18dfffa9a01a8>
.
Anyway, thank you for the (bug) report.
-Marek
On Tue, May 25, 2010 at 9:25 PM, gianluca <gianl...@sottospazio.it> wrote:
> On Tue, May 25, 2010 at 11:57:23AM +0200, Marek Olšák wrote:
> > The patch looks good but it's r5xx-only. I'll commit this when an r3xx
> > version is implemented too.
>
> yes I realized that the opcode is R500 only. I've taken a different
> approach
> using transformations which works too, but I don't know if it's acceptable.
>
> I'm attaching the patch which also handles the SLE case.
>
> >
> > -Marek
> >
> > On Mon, May 24, 2010 at 6:00 PM, Gianluca Anzolin
> > <gianl...@sottospazio.it>wrote:
> >
> > > Hello,
> > >
> > > Yesterday I was trying to run an example taken from chapter 6 of the
> book
> > > OpenGl
> > > Shading Language with the new gallium driver (I have a RV570 graphic
> card),
> > > but
> > > I got this error when compiling the vertex shader: Unknown opcode 35.
> > >
> > > Digging in the source code I found that the opcode 35 is for the >
> operator
> > > between two vectors (RC_OPCODE_SGT). It's related to the following
> vertex
> > > shader code:
> > >
> > > if (diffuse > 0.0)
> > > {
> > > spec = max(dot(reflectVec, viewVec), 0.0);
> > > spec = pow(spec, 16.0);
> > > }
> > >
> > >
> > >
> > > When I changed the comparison to ">=" the problem disappeared. Infact
> there
> > > is
> > > no switch case for RC_OPCODE_SGT in the file r3xx_vertprog.c. I added
> that
> > > case
> > > to the switch statement (see the patch attached) and I got it working
> even
> > > with
> > > the ">" operator.
> > >
> > > I hope the patch is correct, if there is a better fix I'd really like
> to
> > > know.
> > >
> > > Thanks,
> > >
> > > Gianluca
> > >
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev@lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > >
> > >
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
