On Thu, 2010-06-03 at 13:26 -0700, Roland Scheidegger wrote:
> Hi,
>
> I've created a new branch gallium-array-textures which has some more
> interface changes, this time to support array textures basically.
> Nothing has been adapted to these changes yet (I'll do that it should be
> mostly trivial as long as array textures aren't actually supported by
> the driver or even mesa state tracker), but now would be a good time if
> you have some comments for the proposed interface changes.
>
> Roland
Roland,
This looks great!
Couple of comments -- you're now using the term "layer" in various
places, but there is no strong definition of what that means - except in
the patch comment, which isn't useful once the patch is committed. Can
you define this term somewhere in the documentation?
Also, there are a couple of things that look like typos in the interface
change diff, but I'm sure you'll find those the first time you try to
compile this. eg:
void (*resource_copy_region)(struct pipe_context *pipe,
struct pipe_resource *dst,
- struct pipe_subresource subdst,
+ unsigned level,
unsigned dstx, unsigned dsty, unsigned dstz,
struct pipe_resource *src,
- struct pipe_subresource subsrc,
- unsigned srcx, unsigned srcy, unsigned srcz,
- unsigned width, unsigned height);
+ unsigned level,
+ const struct pipe_box *);
It seems like you end up with two parameters named "level" ??
Otherwise, it looks like a nice cleanup in addition to the new
functionality.
Keith
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
