https://bugs.freedesktop.org/show_bug.cgi?id=29910

--- Comment #5 from Ian Romanick <i...@freedesktop.org> 2010-09-03 15:22:38 PDT 
---
Review of attachment 38410:
 --> (https://bugs.freedesktop.org/review?bug=29910&attachment=38410)

I see two minor problems with the patch.

1. I think we still need GL_VERSION_2_1_functions to show up in the extensions
list.  Otherwise there are cases where the new functions won't be available
from GetProcAddress.  The r300 driver handles this a different way, so i965
could just copy that.

2. GLSL ES needs 100 to be a valid GLSL version.

Other than that, it looks great to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to