-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chad Versace wrote: > In file glsl_parser.ypp, within the production rule of layout_qualifier_id, > factor out the logic for extension ARB_fragment_coord_conventions into its own > function. > > Rationale: A future commit will add to this production rule extra logic for > extension AMD_conservative_depth. If the logic for both extensions were > contained within the production rule, this would result in an ugly > proliferation of boolean flags and if/else trees.
I think these functions should be moved to glsl_parser_extras.cpp. All of the other "parser helper" functions live there. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzFrD8ACgkQX1gOwKyEAw9pjQCfd8XOwa2O3Fhr/wkj16Wv7Iue qkUAoJZPNfnlkY+MnP8SVtC12KZB+N4J =7A8i -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
