On 12/07/2010 11:26 AM, Jakob Bornecrantz wrote:
Hi all
two small patches for the draw module. First remove reduced_prim
> from the draw module seems to never be used and only causes
unnecessary flushes.
I applied the patch here and didn't find any regressions with the
tests I ran. I seem to remember a case where this mattered, but I
don't remember what that is anymore.
I think we can apply it, but be on the lookout for regressions.
Second makes the vertex_info struct smaller, now
I seem to remember msvc not supporting ushort bitfields.
gcc -pedantic also warns:
../../../../src/gallium/auxiliary/draw/draw_vertex.h:87: warning: type
of bit-field ‘interp_mode’ is a GCC extension
../../../../src/gallium/auxiliary/draw/draw_vertex.h:88: warning: type
of bit-field ‘emit’ is a GCC extension
../../../../src/gallium/auxiliary/draw/draw_vertex.h:89: warning: type
of bit-field ‘src_index’ is a GCC extension
I've been using -pedantic in the linux-llvm-debug config file but I'll
probably yank it because there's other places where we're already
using ushort or ubyte bitfields and getting tons of warnings.
-Brian
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
