-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/01/2011 07:12 AM, José Fonseca wrote: > On 03/31/2011 09:45 PM, Ian Romanick wrote: >>> + glVertexPointer(2, GL_FLOAT, vertex_stride, (const >>> void*)(intptr_t)vertex_offset); >>> + glDrawRangeElements(GL_TRIANGLES, >>> + min_index, >>> + max_index, >>> + index_count, >>> + GL_UNSIGNED_SHORT, >>> + (const void*)(intptr_t)index_offset); >>> + assert(glGetError() == GL_NO_ERROR); >>> + glFinish(); >>> >> Why? Both for this finish and the one below. > > It helps matching the above printf output with the crashes. Because > unlike most other tests this test does not use glReadPixels, so unless > we call glFinish the draw can be batched and the cpu crash / gpu crash > could happen much later.
Ah. That makes sense. A comment would help. :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk2WG2QACgkQX1gOwKyEAw/K8ACfQl7XtHb6H19Y0JIrtVxHKaCE EHkAoJCUZxI1L+6rG4J/wTPvNBNlRHU4 =hcng -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
