On Wed, 15 Jun 2011 15:54:13 -0700, Chad Versace <c...@chad-versace.us> wrote: > Replace instances of > irb->region = region > with > intel_region_reference(&irb->region, region) > > Signed-off-by: Chad Versace <c...@chad-versace.us>
intel_region_alloc returns something with a refcount of 1 -- the reference you got from the return value. You're now increasing its reference on assignment, without decrementing its reference when you exit the function and no longer need the reference inside the function. In other words, this change doesn't make sense to me, as it looks like you'll just leak a ref.
pgp79qNiMqRSM.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
