On 08/01/2011 06:18 PM, Ian Romanick wrote: > On 08/01/2011 11:39 AM, Eric Anholt wrote: >> On Mon, 1 Aug 2011 10:20:22 -0700, "Ian Romanick" <i...@freedesktop.org> >> wrote: >>> From: Ian Romanick <ian.d.roman...@intel.com> >>> >>> So far this can only happen in GLSL shaders that contain flow-control >>> that could not be lowered. These programs would have failed to run on >>> hardware anyway. > >> This looks reasonable, but I don't understand why this "can only happen" >> with flow control. Couldn't we just have something with too many temps >> involved without flow control? > > I suppose the more correct comment would be "I've only seen this occur > in GLSL shaders that contain flow-control that could not be lowered." I > don't think it can happen outside GLSL because the assembly extensions > can reject (at the core Mesa level) programs that use too many temps. > > How does this sound: > > This can only happen in GLSL shaders because assembly shaders that use > too many temps are rejected by core Mesa. It is easiest to make this > happen with shaders that contain flow-control that could not be lowered.
This makes more sense. Looks good. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
