On 12/01/2015 02:13 AM, Timothy Arceri wrote:
Just because the validation passed the last time is was called doesn't
automatically mean it will pass again the next time its called.

This is a rather large hammer though :/ Maybe we should look at invalidating the pipeline when samplers are changed instead. Was there other issues this resolves/fixes than sampler validation?

Cc: "11.1" <[email protected]>
https://bugs.freedesktop.org/show_bug.cgi?id=93180
---
  src/mesa/main/context.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index be542dd..11747d9 100644
--- a/src/mesa/main/context.c
+++ b/src/mesa/main/context.c
@@ -2030,7 +2030,7 @@ _mesa_valid_to_render(struct gl_context *ctx, const char 
*where)
     }
/* A pipeline object is bound */
-   if (ctx->_Shader->Name && !ctx->_Shader->Validated) {
+   if (ctx->_Shader->Name) {
        /* Error message will be printed inside _mesa_validate_program_pipeline.
         */
        if (!_mesa_validate_program_pipeline(ctx, ctx->_Shader, GL_TRUE)) {

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to