https://bugs.freedesktop.org/show_bug.cgi?id=39588
--- Comment #10 from [email protected] 2011-08-10 19:20:07 PDT --- (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Created an attachment (id=49902) View: https://bugs.freedesktop.org/attachment.cgi?id=49902 Review: https://bugs.freedesktop.org/review?bug=39588&attachment=49902 [details] > > > intel: Set ctx's drawbuffer according to drawables visual > > This patch doesn't seem like the right fix, and the commit message is a bit > confusing to me (see below). What particularly concerns me is that the change > that created the bug was in common code, but the fix is in driver code. Does > this leave other drivers broken? > > > egl_dri2 creates contexts with a doubleBufferConfig when PIXMAP and > > WINDOW bit is request, so _mesa_init_color sets DrawBuffer[0] to > > GL_BACK. > > I'm confused about this. The application creates a context with a particular > fbconfig, and that determines whether the context is single-buffered or > double-buffered. What does egl_dri2 have to do with anything? > > > If a pixmap surface is created egl_dri2 will use a single buffer config, > > so MakeCurrent has to adjust DrawBuffer[0] to the current drawable. > > One other nit with the commit message. The usual way to reference a bug is: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=39588 > > This makes it easier to search in 'git log' for things to cherry pick to > stable > branches. > > > I just try your patch. > > ./xeglgears -pixmap works fine > > Do the other modes mentioned in comment #0 also work? > > > but > > ./xeglgears -pixmap -fullscreen doesn't work > > > > The pixmap fullscreen mode doesn't work out on both the 7.9 and 7.11. > > If fullscreen didn't work with Mesa 7.9, it's not the same bug. > > > Would you mind helping me looking into this issue. Thanks a lot. Sorry for the late response. GL_RENDERER = Mesa DRI Intel(R) IGD x86/MMX/SSE2 GL_VERSION = 1.4 Mesa 7.12-devel (git-4dd3272) ./xeglgears -pixmap works ./xeglgears -pixmap-texture works ./xeglgears -pixmap -fullscreen doesn't work ./xeglgears -pixmap-texture -fullscreen works ./xeglgears -pbuffer works ./xeglgears -pbuffer-texture works ./xeglgears -pbuffer -fullscreen works ./xeglgears -pbuffer-texture -fullscreen works Hope that can help you. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
