Thanks Sarah. I'll turn on KBL testing in the CI. Sarah Sharp <sarah.a.sh...@linux.intel.com> writes:
> From: Mark Janes <mark.a.ja...@intel.com> > > In testing KBL, I found: > > - urb size was not set for slices gt1.5, gt2, and gt3. The value I > used for these slices (384) was taken from an earlier patch authored > by Ben Widawsky. > > - slice count was missing. This field was added by > a403ad4f5a034e52a3cd845e91c4aa3e6927b731 > > With this commit, KBL passes piglit at parity with SKL. > > Note: As requested by Kristian, Sarah modified this patch to drop > setting urb size for gt1.5, gt2, and gt3, since the correct default is > set in the GEN9 macro by commit c1e38ad37042b0ec261eb0ba5631b7ff0ee7a9da > "i965/skl: Use larger URB size where available." > > Signed-off-by: Mark Janes <mark.a.ja...@intel.com> > Signed-off-by: Sarah Sharp <sarah.a.sh...@linux.intel.com> > Reviewed-by: Kristian Høgsberg Kristensen <kristian.h.kristen...@intel.com> > Cc: "11.1" <mesa-sta...@lists.freedesktop.org> > --- > src/mesa/drivers/dri/i965/brw_device_info.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c > b/src/mesa/drivers/dri/i965/brw_device_info.c > index 42bcb98..b8148bf 100644 > --- a/src/mesa/drivers/dri/i965/brw_device_info.c > +++ b/src/mesa/drivers/dri/i965/brw_device_info.c > @@ -420,6 +420,7 @@ static const struct brw_device_info > brw_device_info_kbl_gt1 = { > .max_cs_threads = 7 * 6, > .max_wm_threads = KBL_MAX_THREADS_PER_PSD * 2, > .urb.size = 192, > + .num_slices = 1, > }; > > static const struct brw_device_info brw_device_info_kbl_gt1_5 = { > @@ -428,6 +429,7 @@ static const struct brw_device_info > brw_device_info_kbl_gt1_5 = { > > .max_cs_threads = 7 * 6, > .max_wm_threads = KBL_MAX_THREADS_PER_PSD * 3, > + .num_slices = 1, > }; > > static const struct brw_device_info brw_device_info_kbl_gt2 = { > @@ -435,6 +437,7 @@ static const struct brw_device_info > brw_device_info_kbl_gt2 = { > .gt = 2, > > .max_wm_threads = KBL_MAX_THREADS_PER_PSD * 3, > + .num_slices = 1, > }; > > static const struct brw_device_info brw_device_info_kbl_gt3 = { > @@ -442,6 +445,7 @@ static const struct brw_device_info > brw_device_info_kbl_gt3 = { > .gt = 3, > > .max_wm_threads = KBL_MAX_THREADS_PER_PSD * 6, > + .num_slices = 2, > }; > > static const struct brw_device_info brw_device_info_kbl_gt4 = { > @@ -460,6 +464,7 @@ static const struct brw_device_info > brw_device_info_kbl_gt4 = { > * will be used." > */ > .urb.size = 1008 / 3, > + .num_slices = 3, > }; > > const struct brw_device_info * > -- > 2.3.0 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev